[<prev] [next>] [day] [month] [year] [list]
Message-ID: <202504270342.FU9iqFuX-lkp@intel.com>
Date: Sun, 27 Apr 2025 03:57:04 +0800
From: kernel test robot <lkp@...el.com>
To: Peterson Guo <peterson.guo@....com>
Cc: oe-kbuild-all@...ts.linux.dev, linux-kernel@...r.kernel.org,
Alex Deucher <alexander.deucher@....com>,
Alvin Lee <alvin.lee2@....com>, Wayne Lin <wayne.lin@....com>,
linux-doc@...r.kernel.org
Subject: drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_resource.c:1667:
warning: This comment starts with '/**', but isn't a kernel-doc comment.
Refer Documentation/doc-guide/kernel-doc.rst
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 02ddfb981de88a2c15621115dd7be2431252c568
commit: 3c50bf2196aaddcaffe2c7a1a7080470380cbfdd drm/amd/display: Reverse the visual confirm recouts
date: 2 months ago
config: sparc64-randconfig-001-20250426 (https://download.01.org/0day-ci/archive/20250427/202504270342.FU9iqFuX-lkp@intel.com/config)
compiler: sparc64-linux-gcc (GCC) 7.5.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250427/202504270342.FU9iqFuX-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202504270342.FU9iqFuX-lkp@intel.com/
All warnings (new ones prefixed by >>):
>> drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_resource.c:1667: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
* Disable the cursor if there's another pipe above this with a
drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_resource.c:1687: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
* There is another half plane on same layer because of
vim +1667 drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_resource.c
1654
1655 bool resource_can_pipe_disable_cursor(struct pipe_ctx *pipe_ctx)
1656 {
1657 struct pipe_ctx *test_pipe, *split_pipe;
1658 struct rect r1 = pipe_ctx->plane_res.scl_data.recout;
1659 int r1_right, r1_bottom;
1660 int cur_layer = pipe_ctx->plane_state->layer_index;
1661
1662 reverse_adjust_recout_for_visual_confirm(&r1, pipe_ctx);
1663 r1_right = r1.x + r1.width;
1664 r1_bottom = r1.y + r1.height;
1665
1666 /**
> 1667 * Disable the cursor if there's another pipe above this with a
1668 * plane that contains this pipe's viewport to prevent double cursor
1669 * and incorrect scaling artifacts.
1670 */
1671 for (test_pipe = pipe_ctx->top_pipe; test_pipe;
1672 test_pipe = test_pipe->top_pipe) {
1673 struct rect r2;
1674 int r2_right, r2_bottom;
1675 // Skip invisible layer and pipe-split plane on same layer
1676 if (!test_pipe->plane_state ||
1677 !test_pipe->plane_state->visible ||
1678 test_pipe->plane_state->layer_index == cur_layer)
1679 continue;
1680
1681 r2 = test_pipe->plane_res.scl_data.recout;
1682 reverse_adjust_recout_for_visual_confirm(&r2, test_pipe);
1683 r2_right = r2.x + r2.width;
1684 r2_bottom = r2.y + r2.height;
1685
1686 /**
1687 * There is another half plane on same layer because of
1688 * pipe-split, merge together per same height.
1689 */
1690 for (split_pipe = pipe_ctx->top_pipe; split_pipe;
1691 split_pipe = split_pipe->top_pipe)
1692 if (split_pipe->plane_state->layer_index == test_pipe->plane_state->layer_index) {
1693 struct rect r2_half;
1694
1695 r2_half = split_pipe->plane_res.scl_data.recout;
1696 reverse_adjust_recout_for_visual_confirm(&r2_half, split_pipe);
1697 r2.x = min(r2_half.x, r2.x);
1698 r2.width = r2.width + r2_half.width;
1699 r2_right = r2.x + r2.width;
1700 r2_bottom = min(r2_bottom, r2_half.y + r2_half.height);
1701 break;
1702 }
1703
1704 if (r1.x >= r2.x && r1.y >= r2.y && r1_right <= r2_right && r1_bottom <= r2_bottom)
1705 return true;
1706 }
1707
1708 return false;
1709 }
1710
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
Powered by blists - more mailing lists