linux-kernel - fs/gfs2/glock.c:1213: warning: Function parameter or struct member 'ip' not described in '__gfs2_holder

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <202504270418.VcPbMEFk-lkp@intel.com>
Date: Sun, 27 Apr 2025 04:28:25 +0800
From: kernel test robot <lkp@...el.com>
To: Andreas Gruenbacher <agruenba@...hat.com>
Cc: oe-kbuild-all@...ts.linux.dev, linux-kernel@...r.kernel.org,
	Bob Peterson <rpeterso@...hat.com>
Subject: fs/gfs2/glock.c:1213: warning: Function parameter or struct member
 'ip' not described in '__gfs2_holder_init'

Hi Andreas,

FYI, the error/warning still remains.

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   02ddfb981de88a2c15621115dd7be2431252c568
commit: b016d9a84abdd2efaa273814eaeb59e112ecffbd gfs2: Save ip from gfs2_glock_nq_init
date:   3 years, 6 months ago
config: csky-randconfig-r036-20230303 (https://download.01.org/0day-ci/archive/20250427/202504270418.VcPbMEFk-lkp@intel.com/config)
compiler: csky-linux-gcc (GCC) 12.4.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250427/202504270418.VcPbMEFk-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202504270418.VcPbMEFk-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> fs/gfs2/glock.c:1213: warning: Function parameter or struct member 'ip' not described in '__gfs2_holder_init'
   fs/gfs2/glock.c:1213: warning: expecting prototype for gfs2_holder_init(). Prototype was for __gfs2_holder_init() instead


vim +1213 fs/gfs2/glock.c

b3b94faa5fe596 David Teigland      2006-01-16  1201  
b3b94faa5fe596 David Teigland      2006-01-16  1202  /**
b3b94faa5fe596 David Teigland      2006-01-16  1203   * gfs2_holder_init - initialize a struct gfs2_holder in the default way
b3b94faa5fe596 David Teigland      2006-01-16  1204   * @gl: the glock
b3b94faa5fe596 David Teigland      2006-01-16  1205   * @state: the state we're requesting
b3b94faa5fe596 David Teigland      2006-01-16  1206   * @flags: the modifier flags
b3b94faa5fe596 David Teigland      2006-01-16  1207   * @gh: the holder structure
b3b94faa5fe596 David Teigland      2006-01-16  1208   *
b3b94faa5fe596 David Teigland      2006-01-16  1209   */
b3b94faa5fe596 David Teigland      2006-01-16  1210  
b016d9a84abdd2 Andreas Gruenbacher 2021-09-30  1211  void __gfs2_holder_init(struct gfs2_glock *gl, unsigned int state, u16 flags,
b016d9a84abdd2 Andreas Gruenbacher 2021-09-30  1212  			struct gfs2_holder *gh, unsigned long ip)
b3b94faa5fe596 David Teigland      2006-01-16 @1213  {
b3b94faa5fe596 David Teigland      2006-01-16  1214  	INIT_LIST_HEAD(&gh->gh_list);
b3b94faa5fe596 David Teigland      2006-01-16  1215  	gh->gh_gl = gl;
b016d9a84abdd2 Andreas Gruenbacher 2021-09-30  1216  	gh->gh_ip = ip;
b1e058da50f793 Pavel Emelyanov     2008-02-07  1217  	gh->gh_owner_pid = get_pid(task_pid(current));
b3b94faa5fe596 David Teigland      2006-01-16  1218  	gh->gh_state = state;
b3b94faa5fe596 David Teigland      2006-01-16  1219  	gh->gh_flags = flags;
b3b94faa5fe596 David Teigland      2006-01-16  1220  	gh->gh_error = 0;
b3b94faa5fe596 David Teigland      2006-01-16  1221  	gh->gh_iflags = 0;
b3b94faa5fe596 David Teigland      2006-01-16  1222  	gfs2_glock_hold(gl);
b3b94faa5fe596 David Teigland      2006-01-16  1223  }
b3b94faa5fe596 David Teigland      2006-01-16  1224  

:::::: The code at line 1213 was first introduced by commit
:::::: b3b94faa5fe5968827ba0640ee9fba4b3e7f736e [GFS2] The core of GFS2

:::::: TO: David Teigland <teigland@...hat.com>
:::::: CC: Steven Whitehouse <swhiteho@...hat.com>

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki