linux-kernel - Re: [PATCH v4 2/4] serial: 8250: introduce serial8250_discard

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202504261249.RVGiOFHl-lkp@intel.com>
Date: Sat, 26 Apr 2025 12:47:09 +0800
From: kernel test robot <lkp@...el.com>
To: Yunhui Cui <cuiyunhui@...edance.com>, arnd@...db.de,
	andriy.shevchenko@...ux.intel.com, benjamin.larsson@...exis.eu,
	gregkh@...uxfoundation.org, heikki.krogerus@...ux.intel.com,
	ilpo.jarvinen@...ux.intel.com, jirislaby@...nel.org,
	jkeeping@...usicbrands.com, john.ogness@...utronix.de,
	linux-kernel@...r.kernel.org, linux-serial@...r.kernel.org,
	markus.mayer@...aro.org, matt.porter@...aro.org,
	namcao@...utronix.de, paulmck@...nel.org, pmladek@...e.com,
	schnelle@...ux.ibm.com, sunilvl@...tanamicro.com,
	tim.kryger@...aro.org
Cc: oe-kbuild-all@...ts.linux.dev
Subject: Re: [PATCH v4 2/4] serial: 8250: introduce serial8250_discard_data()

Hi Yunhui,

kernel test robot noticed the following build errors:

[auto build test ERROR on soc/for-next]
[cannot apply to tty/tty-testing tty/tty-next tty/tty-linus usb/usb-testing usb/usb-next usb/usb-linus linus/master v6.15-rc3 next-20250424]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Yunhui-Cui/serial-8250-introduce-serial8250_discard_data/20250425-142655
base:   https://git.kernel.org/pub/scm/linux/kernel/git/soc/soc.git for-next
patch link:    https://lore.kernel.org/r/20250425062425.68761-2-cuiyunhui%40bytedance.com
patch subject: [PATCH v4 2/4] serial: 8250: introduce serial8250_discard_data()
config: sh-allmodconfig (https://download.01.org/0day-ci/archive/20250426/202504261249.RVGiOFHl-lkp@intel.com/config)
compiler: sh4-linux-gcc (GCC) 14.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250426/202504261249.RVGiOFHl-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202504261249.RVGiOFHl-lkp@intel.com/

All error/warnings (new ones prefixed by >>):

   drivers/tty/serial/8250/8250_port.c: In function 'serial8250_get_poll_char':
>> drivers/tty/serial/8250/8250_port.c:2146:39: error: 'flags' undeclared (first use in this function)
    2146 |         uart_port_lock_irqsave(port, &flags);
         |                                       ^~~~~
   drivers/tty/serial/8250/8250_port.c:2146:39: note: each undeclared identifier is reported only once for each function it appears in
>> drivers/tty/serial/8250/8250_port.c:2151:1: warning: label 'out' defined but not used [-Wunused-label]
    2151 | out:
         | ^~~


vim +/flags +2146 drivers/tty/serial/8250/8250_port.c

  2131	
  2132	#ifdef CONFIG_CONSOLE_POLL
  2133	/*
  2134	 * Console polling routines for writing and reading from the uart while
  2135	 * in an interrupt or debug context.
  2136	 */
  2137	
  2138	static int serial8250_get_poll_char(struct uart_port *port)
  2139	{
  2140		struct uart_8250_port *up = up_to_u8250p(port);
  2141		int status = NO_POLL_CHAR;
  2142		u16 lsr;
  2143	
  2144		serial8250_rpm_get(up);
  2145	
> 2146		uart_port_lock_irqsave(port, &flags);
  2147		lsr = serial_port_in(port, UART_LSR);
  2148		if ((lsr & UART_LSR_DR))
  2149			status = serial_port_in(port, UART_RX);
  2150		uart_port_unlock_irqrestore(port, flags);
> 2151	out:
  2152		serial8250_rpm_put(up);
  2153		return status;
  2154	}
  2155	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki