[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-ID: <20250427070135.884623-1-quic_vikramsa@quicinc.com>
Date: Sun, 27 Apr 2025 12:31:26 +0530
From: Vikram Sharma <quic_vikramsa@...cinc.com>
To: <rfoss@...nel.org>, <todor.too@...il.com>, <bryan.odonoghue@...aro.org>,
<mchehab@...nel.org>, <robh@...nel.org>, <krzk+dt@...nel.org>,
<conor+dt@...nel.org>, <andersson@...nel.org>,
<konradybcio@...nel.org>, <hverkuil-cisco@...all.nl>,
<cros-qcom-dts-watchers@...omium.org>, <catalin.marinas@....com>,
<will@...nel.org>
CC: <linux-arm-kernel@...ts.infradead.org>, <quic_vikramsa@...cinc.com>,
<linux-media@...r.kernel.org>, <linux-arm-msm@...r.kernel.org>,
<devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: [PATCH v2 RFC/WIP 0/9] Add sa8775p camss support
From: Vikram Sharma <vikramsa@....qualcomm.com>
Posting these changes as RFC/WIP because there is some renaming done for
existing files so that same files can be used for multiple vfe/csid
version.
SA8775P is a Qualcomm SoC. This series adds bindings and devicetree to bring
up CSIPHY, TPG, CSID, VFE/RDI interfaces in SA8775P.
SA8775P provides
- 2 x VFE, 3 RDI per VFE
- 5 x VFE Lite, 6 RDI per VFE
- 2 x CSID
- 5 x CSID Lite
- 3 x TPG
- 4 x CSIPHY
Changes compared to v1:
- Renaming camss-vfe-780.c to camss-vfe-gen2.c and camss-csid-780 to
camss-csid-gen3 to avoid code duplication for SA8775P.SA877P have csid
690 and vfe 690 which is almost same as csid/vfe 780 with very minor
change in register bitfield.
- Restructure vfe and csid addition to reuse existing files.
- Updated cisd-lite and vfe-lite interuppt names.
- add enumeration changes as seprate patch.
- Update required fileds in bindings.
- Link to v1:
DT: https://lore.kernel.org/linux-arm-msm/20250210155605.575367-1-quic_vikramsa@quicinc.com/
Driver: https://lore.kernel.org/linux-media/20250210162843.609337-1-quic_vikramsa@quicinc.com/
Sanity check for these patches:
- make CHECK_DTBS=y W=1 DT_SCHEMA_FILES=media/qcom,sa8775p-camss.yaml
- make DT_CHECKER_FLAGS=-m W=1
DT_SCHEMA_FILES=media/qcom,sa8775p-camss.yaml dt_binding_check
- checkpatch.pl
- Smatch: make CHECK="smatch --full-path" M=drivers/media/platform/qcom/camss/
- Sparse: make C=2 M=drivers/media/platform/qcom/camss/
- make -j32 W=1
We have tested this on qcs9100-ride board with 'Test Pattern Generator'
TPG driver support will be posted in a follow up series.
Tested with following commands:
- media-ctl -d /dev/media0 --reset
- yavta --no-query -w '0x009f0903 0' /dev/v4l-subdev0
- media-ctl -d /dev/media0 -V '"msm_tpg0":0[fmt:SRGGB10/1920x1080
field:none]'
- media-ctl -d /dev/media0 -V '"msm_csid0":0[fmt:SRGGB10/1920x1080
field:none]'
- media-ctl -d /dev/media0 -V '"msm_vfe0_rdi0":0[fmt:SRGGB10/1920x1080
field:none]'
- media-ctl -d /dev/media0 -l '"msm_tpg0":1->"msm_csid0":0[1]'
- media-ctl -d /dev/media0 -l '"msm_csid0":1->"msm_vfe0_rdi0":0[1]'
- yavta --no-query -w '0x009f0903 9' /dev/v4l-subdev0
- yavta -B capture-mplane -n 5 -f SRGGB10P -s 1920x1080 /dev/video0
--capture=7
Signed-off-by: Vikram Sharma <quic_vikramsa@...cinc.com>
Vikram Sharma (9):
media: qcom: camss: add generic csid handling in csid gen3
media: qcom: camss: add generic vfe handling in vfe gen3
media: dt-bindings: Add qcom,sa8775p-camss
arm64: dts: qcom: sa8775p: Add support for camss
media: qcom: camss: Add sa8775p compatible
media: qcom: camss: Add support for CSIPHY 690
media: qcom: camss: Add support for CSID for sa8775p
media: qcom: camss: Add support for VFE 690
media: qcom: camss: Enumerate resources for SA8775P
.../bindings/media/qcom,sa8775p-camss.yaml | 352 +++++++++++++
arch/arm64/boot/dts/qcom/sa8775p.dtsi | 187 +++++++
drivers/media/platform/qcom/camss/Makefile | 4 +-
.../{camss-csid-780.c => camss-csid-gen3.c} | 42 +-
.../{camss-csid-780.h => camss-csid-gen3.h} | 9 +-
.../media/platform/qcom/camss/camss-csid.h | 2 +-
.../qcom/camss/camss-csiphy-3ph-1-0.c | 84 ++++
.../media/platform/qcom/camss/camss-csiphy.c | 5 +
.../media/platform/qcom/camss/camss-csiphy.h | 1 +
.../{camss-vfe-780.c => camss-vfe-gen3.c} | 9 +-
drivers/media/platform/qcom/camss/camss-vfe.c | 5 +-
drivers/media/platform/qcom/camss/camss-vfe.h | 2 +-
drivers/media/platform/qcom/camss/camss.c | 461 +++++++++++++++++-
drivers/media/platform/qcom/camss/camss.h | 1 +
14 files changed, 1130 insertions(+), 34 deletions(-)
create mode 100644 Documentation/devicetree/bindings/media/qcom,sa8775p-camss.yaml
rename drivers/media/platform/qcom/camss/{camss-csid-780.c => camss-csid-gen3.c} (87%)
rename drivers/media/platform/qcom/camss/{camss-csid-780.h => camss-csid-gen3.h} (84%)
rename drivers/media/platform/qcom/camss/{camss-vfe-780.c => camss-vfe-gen3.c} (95%)
--
2.25.1
Powered by blists - more mailing lists