linux-kernel - Re: [PATCH] ALSA: hda/hda_cs_dsp_ctl: Delete hda_cs_dsp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87seluxc98.wl-tiwai@suse.de>
Date: Sun, 27 Apr 2025 10:02:59 +0200
From: Takashi Iwai <tiwai@...e.de>
To: Richard Fitzgerald <rf@...nsource.cirrus.com>
Cc: tiwai@...e.com,
	linux-sound@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	patches@...nsource.cirrus.com
Subject: Re: [PATCH] ALSA: hda/hda_cs_dsp_ctl: Delete hda_cs_dsp_ctl module

On Thu, 24 Apr 2025 20:12:14 +0200,
Richard Fitzgerald wrote:
> 
> Delete the hda_cs_dsp module and move the one array and one function
> that is used by the cs35l41_hda driver into that driver.
> 
> The cs35l41 and cs35l56 drivers stopped creating ALSA controls to
> wrap firmware controls. The reasons are explained in:
> 
> commit 312c04cee408 ("ALSA: hda: cs35l41: Stop creating ALSA Controls
> for firmware coefficients")
> 
> and
> 
> commit 34e1b1bb7324 ("ALSA: hda: cs35l56: Stop creating ALSA controls
> for firmware coefficients")
> 
> The cs35l56_hda driver now doesn't use hda_cs_dsp_ctl at all. The
> cs35l41_hda driver only uses the small array of firmware names and the
> function to read a control value. All other functions and data in
> hda_cs_dsp_ctl are unused. There is no need to keep a separate module
> for such a small amount of data and code that is only used by one driver,
> so remove the whole module.
> 
> Signed-off-by: Richard Fitzgerald <rf@...nsource.cirrus.com>

Thanks, applied now to for-next branch.


Takashi