linux-kernel - [PATCH] regmap: Remove unused regmap_field_bulk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20250427012250.244752-1-linux@treblig.org>
Date: Sun, 27 Apr 2025 02:22:50 +0100
From: linux@...blig.org
To: broonie@...nel.org,
	gregkh@...uxfoundation.org,
	rafael@...nel.org,
	dakr@...nel.org
Cc: linux-kernel@...r.kernel.org,
	"Dr. David Alan Gilbert" <linux@...blig.org>
Subject: [PATCH] regmap: Remove unused regmap_field_bulk_(alloc,free)

From: "Dr. David Alan Gilbert" <linux@...blig.org>

regmap_field_bulk_alloc() and regmap_field_bulk_free() were added in
2020 by
commit ea470b82f205 ("regmap: add support to regmap_field_bulk_alloc/free
apis")

but have remained unused.

Remove them.

The devm_ versions are still used and are left alone.

Signed-off-by: Dr. David Alan Gilbert <linux@...blig.org>
---
 drivers/base/regmap/regmap.c | 46 ------------------------------------
 include/linux/regmap.h       |  5 ----
 2 files changed, 51 deletions(-)

diff --git a/drivers/base/regmap/regmap.c b/drivers/base/regmap/regmap.c
index f2843f814675..b805753fc556 100644
--- a/drivers/base/regmap/regmap.c
+++ b/drivers/base/regmap/regmap.c
@@ -1248,40 +1248,6 @@ struct regmap_field *devm_regmap_field_alloc(struct device *dev,
 }
 EXPORT_SYMBOL_GPL(devm_regmap_field_alloc);
 
-
-/**
- * regmap_field_bulk_alloc() - Allocate and initialise a bulk register field.
- *
- * @regmap: regmap bank in which this register field is located.
- * @rm_field: regmap register fields within the bank.
- * @reg_field: Register fields within the bank.
- * @num_fields: Number of register fields.
- *
- * The return value will be an -ENOMEM on error or zero for success.
- * Newly allocated regmap_fields should be freed by calling
- * regmap_field_bulk_free()
- */
-int regmap_field_bulk_alloc(struct regmap *regmap,
-			    struct regmap_field **rm_field,
-			    const struct reg_field *reg_field,
-			    int num_fields)
-{
-	struct regmap_field *rf;
-	int i;
-
-	rf = kcalloc(num_fields, sizeof(*rf), GFP_KERNEL);
-	if (!rf)
-		return -ENOMEM;
-
-	for (i = 0; i < num_fields; i++) {
-		regmap_field_init(&rf[i], regmap, reg_field[i]);
-		rm_field[i] = &rf[i];
-	}
-
-	return 0;
-}
-EXPORT_SYMBOL_GPL(regmap_field_bulk_alloc);
-
 /**
  * devm_regmap_field_bulk_alloc() - Allocate and initialise a bulk register
  * fields.
@@ -1318,18 +1284,6 @@ int devm_regmap_field_bulk_alloc(struct device *dev,
 }
 EXPORT_SYMBOL_GPL(devm_regmap_field_bulk_alloc);
 
-/**
- * regmap_field_bulk_free() - Free register field allocated using
- *                       regmap_field_bulk_alloc.
- *
- * @field: regmap fields which should be freed.
- */
-void regmap_field_bulk_free(struct regmap_field *field)
-{
-	kfree(field);
-}
-EXPORT_SYMBOL_GPL(regmap_field_bulk_free);
-
 /**
  * devm_regmap_field_bulk_free() - Free a bulk register field allocated using
  *                            devm_regmap_field_bulk_alloc.
diff --git a/include/linux/regmap.h b/include/linux/regmap.h
index d17c5ea3d55d..d4e9b39f1946 100644
--- a/include/linux/regmap.h
+++ b/include/linux/regmap.h
@@ -1444,11 +1444,6 @@ struct regmap_field *devm_regmap_field_alloc(struct device *dev,
 		struct regmap *regmap, struct reg_field reg_field);
 void devm_regmap_field_free(struct device *dev,	struct regmap_field *field);
 
-int regmap_field_bulk_alloc(struct regmap *regmap,
-			     struct regmap_field **rm_field,
-			     const struct reg_field *reg_field,
-			     int num_fields);
-void regmap_field_bulk_free(struct regmap_field *field);
 int devm_regmap_field_bulk_alloc(struct device *dev, struct regmap *regmap,
 				 struct regmap_field **field,
 				 const struct reg_field *reg_field,
-- 
2.49.0