linux-kernel - drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c:2168: warning: Function parameter or struct member 'AMDGPU_RAS_BLOCK_

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <202504271826.xy2fFO28-lkp@intel.com>
Date: Sun, 27 Apr 2025 18:22:05 +0800
From: kernel test robot <lkp@...el.com>
To: Lijo Lazar <lijo.lazar@....com>
Cc: oe-kbuild-all@...ts.linux.dev, linux-kernel@...r.kernel.org,
	Alex Deucher <alexander.deucher@....com>,
	Hawking Zhang <Hawking.Zhang@....com>
Subject: drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c:2168: warning: Function
 parameter or struct member 'AMDGPU_RAS_BLOCK__ANY' not described in 'if'

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   02ddfb981de88a2c15621115dd7be2431252c568
commit: e1ee2111ca48169a9fdc5075f7863f5d4d591e2f drm/amdgpu: Prefer RAS recovery for scheduler hang
date:   5 months ago
config: sparc-randconfig-001-20250426 (https://download.01.org/0day-ci/archive/20250427/202504271826.xy2fFO28-lkp@intel.com/config)
compiler: sparc64-linux-gcc (GCC) 10.3.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250427/202504271826.xy2fFO28-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202504271826.xy2fFO28-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c:2168: warning: Function parameter or struct member 'AMDGPU_RAS_BLOCK__ANY' not described in 'if'
>> drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c:2168: warning: expecting prototype for If the current interrupt is caused by a non(). Prototype was for if() instead


vim +2168 drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c

  2148	
  2149	/* For the hardware that cannot enable bif ring for both ras_controller_irq
  2150	 * and ras_err_evnet_athub_irq ih cookies, the driver has to poll status
  2151	 * register to check whether the interrupt is triggered or not, and properly
  2152	 * ack the interrupt if it is there
  2153	 */
  2154	void amdgpu_ras_interrupt_fatal_error_handler(struct amdgpu_device *adev)
  2155	{
  2156		/* Fatal error events are handled on host side */
  2157		if (amdgpu_sriov_vf(adev))
  2158			return;
  2159		/**
  2160		 * If the current interrupt is caused by a non-fatal RAS error, skip
  2161		 * check for fatal error. For fatal errors, FED status of all devices
  2162		 * in XGMI hive gets set when the first device gets fatal error
  2163		 * interrupt. The error gets propagated to other devices as well, so
  2164		 * make sure to ack the interrupt regardless of FED status.
  2165		 */
  2166		if (!amdgpu_ras_get_fed_status(adev) &&
  2167		    amdgpu_ras_is_err_state(adev, AMDGPU_RAS_BLOCK__ANY))
> 2168			return;
  2169	
  2170		if (adev->nbio.ras &&
  2171		    adev->nbio.ras->handle_ras_controller_intr_no_bifring)
  2172			adev->nbio.ras->handle_ras_controller_intr_no_bifring(adev);
  2173	
  2174		if (adev->nbio.ras &&
  2175		    adev->nbio.ras->handle_ras_err_event_athub_intr_no_bifring)
  2176			adev->nbio.ras->handle_ras_err_event_athub_intr_no_bifring(adev);
  2177	}
  2178	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki