linux-kernel - Re: [PATCH v1 1/7] mfd: stmpe-spi: Correct the name used in MODULE_DEVICE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <60b92fba-8170-4e9a-bdae-1ad7dd6beefb@kernel.org>
Date: Sun, 27 Apr 2025 13:01:25 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Alexey Gladkov <legion@...nel.org>, Luis Chamberlain <mcgrof@...nel.org>,
 Petr Pavlu <petr.pavlu@...e.com>, Sami Tolvanen <samitolvanen@...gle.com>,
 Daniel Gomez <da.gomez@...sung.com>, Masahiro Yamada <masahiroy@...nel.org>,
 Nathan Chancellor <nathan@...nel.org>,
 Nicolas Schier <nicolas.schier@...ux.dev>
Cc: linux-kernel@...r.kernel.org, linux-modules@...r.kernel.org,
 linux-kbuild@...r.kernel.org, Lee Jones <lee@...nel.org>,
 Maxime Coquelin <mcoquelin.stm32@...il.com>,
 Alexandre Torgue <alexandre.torgue@...s.st.com>
Subject: Re: [PATCH v1 1/7] mfd: stmpe-spi: Correct the name used in
 MODULE_DEVICE_TABLE

On 26/04/2025 18:16, Alexey Gladkov wrote:
> The name used in the macro does not exist.
> 
> drivers/mfd/stmpe-spi.c:132:26: error: use of undeclared identifier 'stmpe_id'
>   132 | MODULE_DEVICE_TABLE(spi, stmpe_id);
>       |                          ^
> 1 error generated.


Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>

P.S. You can trim the error messages to relevant parts, e.g. "1 error
generated" is really redundant and not needed to store in git history.

> 

Best regards,
Krzysztof