linux-kernel - Re: [PATCH v3 1/3] mm/memcg: move mem_cgroup_init() ahead of cgroup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250427114609.GA116315@cmpxchg.org>
Date: Sun, 27 Apr 2025 07:46:09 -0400
From: Johannes Weiner <hannes@...xchg.org>
To: Huan Yang <link@...o.com>
Cc: Michal Hocko <mhocko@...nel.org>,
	Roman Gushchin <roman.gushchin@...ux.dev>,
	Shakeel Butt <shakeel.butt@...ux.dev>,
	Muchun Song <muchun.song@...ux.dev>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Petr Mladek <pmladek@...e.com>, Vlastimil Babka <vbabka@...e.cz>,
	Rasmus Villemoes <linux@...musvillemoes.dk>,
	Francesco Valla <francesco@...la.it>,
	Raul E Rangel <rrangel@...omium.org>,
	"Paul E. McKenney" <paulmck@...nel.org>,
	Huang Shijie <shijie@...amperecomputing.com>,
	Guo Weikang <guoweikang.kernel@...il.com>,
	"Uladzislau Rezki (Sony)" <urezki@...il.com>,
	KP Singh <kpsingh@...nel.org>, cgroups@...r.kernel.org,
	linux-mm@...ck.org, linux-kernel@...r.kernel.org,
	Alexander Gordeev <agordeev@...ux.ibm.com>,
	Boqun Feng <boqun.feng@...il.com>, opensource.kernel@...o.com
Subject: Re: [PATCH v3 1/3] mm/memcg: move mem_cgroup_init() ahead of
 cgroup_init()

On Fri, Apr 25, 2025 at 11:19:23AM +0800, Huan Yang wrote:
> When cgroup_init() creates root_mem_cgroup through css_alloc callback,
> some critical resources might not be fully initialized, forcing later
> operations to perform conditional checks for resource availability.
> 
> This patch move mem_cgroup_init() to address the init order, it invoke
> before cgroup_init, so, compare to subsys_initcall, it can use to prepare
> some key resources before root_mem_cgroup alloc.
> 
> Signed-off-by: Huan Yang <link@...o.com>
> Suggested-by: Shakeel Butt <shakeel.butt@...ux.dev>

Acked-by: Johannes Weiner <hannes@...xchg.org>