linux-kernel - Re: [PATCH 3/3] alarmtimer: switch spin_{lock,unlock}

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d306f10c-457e-493e-8d06-6d9bd90485ea@nfschina.com>
Date: Sun, 27 Apr 2025 10:15:59 +0800
From: Su Hui <suhui@...china.com>
To: Dan Carpenter <dan.carpenter@...aro.org>
Cc: jstultz@...gle.com, tglx@...utronix.de, sboyd@...nel.org,
 linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH 3/3] alarmtimer: switch spin_{lock,unlock}_irqsave() to
 guard()

On 2025/4/25 21:04, Dan Carpenter wrote:
> On Thu, Apr 24, 2025 at 10:48:20PM +0800, Su Hui wrote:
>> @@ -230,15 +226,15 @@ static int alarmtimer_suspend(struct device *dev)
>>   	ktime_t min, now, expires;
>>   	int i, ret, type;
>>   	struct rtc_device *rtc;
>> -	unsigned long flags;
>>   	struct rtc_time tm;
>>   
>> -	spin_lock_irqsave(&freezer_delta_lock, flags);
>> -	min = freezer_delta;
>> -	expires = freezer_expires;
>> -	type = freezer_alarmtype;
>> -	freezer_delta = 0;
>> -	spin_unlock_irqrestore(&freezer_delta_lock, flags);
>> +	scoped_guard(spinlock_irqsave, &freezer_delta_lock) {
>> +		min = freezer_delta;
>> +		expires = freezer_expires;
>> +		type = freezer_alarmtype;
>> +		freezer_delta = 0;
>> +	}
>> +
>>   
> Don't add the extra blank line here.

Will update in v2 patch, thanks for the suggestion.

Su Hui