linux-kernel - Re: [PATCH v8 2/5] auxdisplay: add TI LP5812 4×3 Matrix RGB LED Driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4c17ae51-475e-4bd2-8bbf-c5e3233ef319@infradead.org>
Date: Sun, 27 Apr 2025 09:04:12 -0700
From: Randy Dunlap <rdunlap@...radead.org>
To: Nam Tran <trannamatk@...il.com>, andy@...nel.org
Cc: geert@...ux-m68k.org, robh@...nel.org, krzk+dt@...nel.org,
 conor+dt@...nel.org, christophe.jaillet@...adoo.fr, corbet@....net,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-doc@...r.kernel.org, florian.fainelli@...adcom.com,
 bcm-kernel-feedback-list@...adcom.com, linux-rpi-kernel@...ts.infradead.org,
 linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v8 2/5] auxdisplay: add TI LP5812 4×3 Matrix RGB LED Driver

Hi--

On 4/27/25 1:24 AM, Nam Tran wrote:
> diff --git a/drivers/auxdisplay/Kconfig b/drivers/auxdisplay/Kconfig
> index bedc6133f970..896f02b9a06b 100644
> --- a/drivers/auxdisplay/Kconfig
> +++ b/drivers/auxdisplay/Kconfig
> @@ -539,6 +539,23 @@ config ARM_CHARLCD
>  	  line and the Linux version on the second line, but that's
>  	  still useful.
>  
> +#
> +# TI LP5812 matrix RGB LED driver section
> +#
> +config LP5812

Missing one tab of indentation on all lines below here:

> +tristate "Enable LP5812 support LED matrix 4x3"
> +depends on I2C
> +help
> +  If you say Y here you get support for TI LP5812 LED driver.
> +
> +  The LP5812 is a 4 × 3 matrix RGB LED driver with autonomous
> +  animation engine control.
> +
> +  To compile this driver as a module, choose M here: the
> +  module will be called lp5812.
> +
> +  If unsure, say N.
> +
>  endif # AUXDISPLAY

-- 
~Randy