linux-kernel - Re: [PATCH] drivers: bluetooth: bpa10x: use usb_{get,put}_dev in bpa10x

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <0d52b631-547e-4398-93ba-8e3b3dbd84ca@molgen.mpg.de>
Date: Sun, 27 Apr 2025 21:01:13 +0200
From: Paul Menzel <pmenzel@...gen.mpg.de>
To: Salah Triki <salah.triki@...il.com>
Cc: Marcel Holtmann <marcel@...tmann.org>,
 Luiz Augusto von Dentz <luiz.dentz@...il.com>,
 linux-bluetooth@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drivers: bluetooth: bpa10x: use usb_{get,put}_dev in
 bpa10x_{probe,disconnect}

Dear Salah,


Thank you for your patch.

Am 27.04.25 um 18:23 schrieb Salah Triki:
> Use usb_{get,put}_dev() to update the ref count of udev.

Could you please add why that is better?

> Signed-off-by: Salah Triki <salah.triki@...il.com>
> ---
>   drivers/bluetooth/bpa10x.c | 4 +++-
>   1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/bluetooth/bpa10x.c b/drivers/bluetooth/bpa10x.c
> index 1fa58c059cbf..0b9931311a59 100644
> --- a/drivers/bluetooth/bpa10x.c
> +++ b/drivers/bluetooth/bpa10x.c
> @@ -375,7 +375,7 @@ static int bpa10x_probe(struct usb_interface *intf,
>   	if (!data)
>   		return -ENOMEM;
>   
> -	data->udev = interface_to_usbdev(intf);
> +	data->udev = usb_get_dev(interface_to_usbdev(intf));
>   
>   	init_usb_anchor(&data->tx_anchor);
>   	init_usb_anchor(&data->rx_anchor);
> @@ -422,6 +422,8 @@ static void bpa10x_disconnect(struct usb_interface *intf)
>   
>   	usb_set_intfdata(intf, NULL);
>   
> +	usb_put_dev(data->udev);
> +
>   	hci_unregister_dev(data->hdev);
>   
>   	hci_free_dev(data->hdev);


Kind regards,

Paul