| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <202504280515.4WwtyfOc-lkp@intel.com>
Date: Mon, 28 Apr 2025 05:37:06 +0800
From: kernel test robot <lkp@...el.com>
To: Kairui Song <ryncsn@...il.com>, linux-mm@...ck.org
Cc: oe-kbuild-all@...ts.linux.dev,
Andrew Morton <akpm@...ux-foundation.org>,
Linux Memory Management List <linux-mm@...ck.org>,
Matthew Wilcox <willy@...radead.org>,
David Hildenbrand <david@...hat.com>,
Hugh Dickins <hughd@...gle.com>, Chris Li <chrisl@...nel.org>,
Yosry Ahmed <yosryahmed@...gle.com>,
"Huang, Ying" <ying.huang@...ux.alibaba.com>,
Nhat Pham <nphamcs@...il.com>, Johannes Weiner <hannes@...xchg.org>,
linux-kernel@...r.kernel.org, Kairui Song <kasong@...cent.com>
Subject: Re: [PATCH 5/6] mm: move folio_index to mm/swap.h and remove no
longer needed helper
Hi Kairui,
kernel test robot noticed the following build errors:
[auto build test ERROR on akpm-mm/mm-everything]
url: https://github.com/intel-lab-lkp/linux/commits/Kairui-Song/fuse-drop-usage-of-folio_index/20250428-030234
base: https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-everything
patch link: https://lore.kernel.org/r/20250427185908.90450-6-ryncsn%40gmail.com
patch subject: [PATCH 5/6] mm: move folio_index to mm/swap.h and remove no longer needed helper
config: m68k-allnoconfig (https://download.01.org/0day-ci/archive/20250428/202504280515.4WwtyfOc-lkp@intel.com/config)
compiler: m68k-linux-gcc (GCC) 14.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250428/202504280515.4WwtyfOc-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202504280515.4WwtyfOc-lkp@intel.com/
All errors (new ones prefixed by >>):
mm/page-writeback.c: In function '__folio_mark_dirty':
>> mm/page-writeback.c:2767:50: error: implicit declaration of function 'folio_index'; did you mean 'folio_inode'? [-Wimplicit-function-declaration]
2767 | __xa_set_mark(&mapping->i_pages, folio_index(folio),
| ^~~~~~~~~~~
| folio_inode
--
mm/gup.c: In function 'memfd_pin_folios':
>> mm/gup.c:3652:49: error: implicit declaration of function 'folio_index'; did you mean 'folio_inode'? [-Wimplicit-function-declaration]
3652 | next_idx != folio_index(fbatch.folios[i]))
| ^~~~~~~~~~~
| folio_inode
vim +2767 mm/page-writeback.c
b9ea25152e5636 Konstantin Khlebnikov 2015-04-14 2742
6e1cae881a0646 Matthew Wilcox (Oracle 2021-06-28 2743) /*
dc6e0ae5b1700c Kemeng Shi 2024-04-25 2744 * Mark the folio dirty, and set it dirty in the page cache.
6e1cae881a0646 Matthew Wilcox (Oracle 2021-06-28 2745) *
203a3151661611 Matthew Wilcox (Oracle 2021-05-04 2746) * If warn is true, then emit a warning if the folio is not uptodate and has
6e1cae881a0646 Matthew Wilcox (Oracle 2021-06-28 2747) * not been truncated.
6e1cae881a0646 Matthew Wilcox (Oracle 2021-06-28 2748) *
a8cd9d4ce35eae Shakeel Butt 2024-10-24 2749 * It is the caller's responsibility to prevent the folio from being truncated
a8cd9d4ce35eae Shakeel Butt 2024-10-24 2750 * while this function is in progress, although it may have been truncated
3d84d897920c75 Matthew Wilcox (Oracle 2024-04-16 2751) * before this function is called. Most callers have the folio locked.
3d84d897920c75 Matthew Wilcox (Oracle 2024-04-16 2752) * A few have the folio blocked from truncation through other means (e.g.
3d84d897920c75 Matthew Wilcox (Oracle 2024-04-16 2753) * zap_vma_pages() has it mapped and is holding the page table lock).
3d84d897920c75 Matthew Wilcox (Oracle 2024-04-16 2754) * When called from mark_buffer_dirty(), the filesystem should hold a
3d84d897920c75 Matthew Wilcox (Oracle 2024-04-16 2755) * reference to the buffer_head that is being marked dirty, which causes
3d84d897920c75 Matthew Wilcox (Oracle 2024-04-16 2756) * try_to_free_buffers() to fail.
6e1cae881a0646 Matthew Wilcox (Oracle 2021-06-28 2757) */
203a3151661611 Matthew Wilcox (Oracle 2021-05-04 2758) void __folio_mark_dirty(struct folio *folio, struct address_space *mapping,
6e1cae881a0646 Matthew Wilcox (Oracle 2021-06-28 2759) int warn)
6e1cae881a0646 Matthew Wilcox (Oracle 2021-06-28 2760) {
6e1cae881a0646 Matthew Wilcox (Oracle 2021-06-28 2761) unsigned long flags;
6e1cae881a0646 Matthew Wilcox (Oracle 2021-06-28 2762)
6e1cae881a0646 Matthew Wilcox (Oracle 2021-06-28 2763) xa_lock_irqsave(&mapping->i_pages, flags);
203a3151661611 Matthew Wilcox (Oracle 2021-05-04 2764) if (folio->mapping) { /* Race with truncate? */
203a3151661611 Matthew Wilcox (Oracle 2021-05-04 2765) WARN_ON_ONCE(warn && !folio_test_uptodate(folio));
203a3151661611 Matthew Wilcox (Oracle 2021-05-04 2766) folio_account_dirtied(folio, mapping);
203a3151661611 Matthew Wilcox (Oracle 2021-05-04 @2767) __xa_set_mark(&mapping->i_pages, folio_index(folio),
6e1cae881a0646 Matthew Wilcox (Oracle 2021-06-28 2768) PAGECACHE_TAG_DIRTY);
6e1cae881a0646 Matthew Wilcox (Oracle 2021-06-28 2769) }
6e1cae881a0646 Matthew Wilcox (Oracle 2021-06-28 2770) xa_unlock_irqrestore(&mapping->i_pages, flags);
6e1cae881a0646 Matthew Wilcox (Oracle 2021-06-28 2771) }
6e1cae881a0646 Matthew Wilcox (Oracle 2021-06-28 2772)
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
Powered by blists - more mailing lists