linux-kernel - Re: [PATCH v2] arm64: dts: qcom: msm8998-lenovo-miix-630: add Venus node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAOCk7NrcpwAnUKcVsc5D03Aazt=qWLZB034xa2FH2PF9LuL6ZA@mail.gmail.com>
Date: Mon, 28 Apr 2025 09:40:52 -0600
From: Jeffrey Hugo <jeffrey.l.hugo@...il.com>
To: Dmitry Baryshkov <dmitry.baryshkov@....qualcomm.com>
Cc: Bjorn Andersson <andersson@...nel.org>, Konrad Dybcio <konradybcio@...nel.org>, 
	Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, 
	linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org, 
	linux-kernel@...r.kernel.org, Konrad Dybcio <konrad.dybcio@....qualcomm.com>
Subject: Re: [PATCH v2] arm64: dts: qcom: msm8998-lenovo-miix-630: add Venus node

On Fri, Apr 25, 2025 at 12:28 PM Dmitry Baryshkov
<dmitry.baryshkov@....qualcomm.com> wrote:
>
> Enable Venus on Lenovo Miix 630 and specify corresponding firmware file.

I'm curious, how did this get validated?  I didn't think there was
enough infrastructure enabled on this platform to check that the
lights were even on on in Venus.

>
> Reviewed-by: Konrad Dybcio <konrad.dybcio@....qualcomm.com>
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@....qualcomm.com>
> ---
> Changes in v2:
> - Rebasde on top of linux-next
> - Link to v1: https://lore.kernel.org/r/20250408-miix-630-venus-v1-1-771c330ee279@oss.qualcomm.com
> ---
>  arch/arm64/boot/dts/qcom/msm8998-lenovo-miix-630.dts | 6 ++++++
>  1 file changed, 6 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/msm8998-lenovo-miix-630.dts b/arch/arm64/boot/dts/qcom/msm8998-lenovo-miix-630.dts
> index f160ba562b0af505bdc1357731f75a394b5eeeeb..c11b972771c3881a57ba5a4dfbdcea487da7c6f1 100644
> --- a/arch/arm64/boot/dts/qcom/msm8998-lenovo-miix-630.dts
> +++ b/arch/arm64/boot/dts/qcom/msm8998-lenovo-miix-630.dts
> @@ -100,6 +100,12 @@ i2c5_hid_active: i2c5-hid-active-state {
>         };
>  };
>
> +&venus {
> +       firmware-name = "qcom/msm8998/LENOVO/81F1/qcvss8998.mbn";
> +
> +       status = "okay";
> +};
> +
>  &wifi {
>         qcom,calibration-variant = "Lenovo_Miix630";
>  };
>
> ---
> base-commit: 6ac908f24cd7ddae52c496bbc888e97ee7b033ac
> change-id: 20250408-miix-630-venus-7a0b4f1f3788
>
> Best regards,
> --
> Dmitry Baryshkov <dmitry.baryshkov@....qualcomm.com>
>
>