linux-kernel - Re: [PATCH] fs/netfs/read_collect: remove duplicate line

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <88037.1745854906@warthog.procyon.org.uk>
Date: Mon, 28 Apr 2025 16:41:46 +0100
From: David Howells <dhowells@...hat.com>
To: Max Kellermann <max.kellermann@...os.com>
Cc: dhowells@...hat.com, netfs@...ts.linux.dev,
    linux-kernel@...r.kernel.org
Subject: Re: [PATCH] fs/netfs/read_collect: remove duplicate line

Max Kellermann <max.kellermann@...os.com> wrote:

> The `ret` variable has already been assigned before the `switch`
> block.
> 
> Signed-off-by: Max Kellermann <max.kellermann@...os.com>
> Fixes: e2d46f2ec332 ("netfs: Change the read result collector to only use one work item")

Please hold off on this one.  I want to submit the two patches at the bottom
of here instead:

	https://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git/log/?h=netfs-fixes

	netfs: Fix the request's work item to not require a ref
	netfs: Fix wait/wake to be consistent about the waitqueue used

and this code gets moved and commonalised with the wait-for-write functions.

The reason I haven't posted them yet is that there may be an issue with cifs -
and only in Steve's testfarm - though I'm not sure whether it's actually
directly related to the changes here or whether it was masked just by it.

Thanks,
David