linux-kernel - Re: [PATCH] fs/netfs: remove unused netfs_io

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <88831.1745855591@warthog.procyon.org.uk>
Date: Mon, 28 Apr 2025 16:53:11 +0100
From: David Howells <dhowells@...hat.com>
To: Max Kellermann <max.kellermann@...os.com>
Cc: dhowells@...hat.com, netfs@...ts.linux.dev,
    linux-kernel@...r.kernel.org
Subject: Re: [PATCH] fs/netfs: remove unused netfs_io_request flags

Max Kellermann <max.kellermann@...os.com> wrote:

> NETFS_RREQ_DONT_UNLOCK_FOLIOS has never been used ever since it was
> added by commit 3d3c95046742 ("netfs: Provide readahead and readpage
> netfs helpers").

I'm fine with removing DONT_UNLOCK_FOLIOS.

> NETFS_RREQ_BLOCKED was added by commit 016dc8516aec ("netfs: Implement
> unbuffered/DIO read support") but has never been used either.  Without
> NETFS_RREQ_BLOCKED, NETFS_RREQ_NONBLOCK makes no sense, and thus can
> be removed as well.

I'm less fine with removing the NONBLOCK handling I might need it for the ceph
conversion, so I think I'll split the patch in two.

David