linux-kernel - Re: [PATCH] ptp: ocp: Add const to bp->attr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1fd10ea8-335b-4007-b188-4cf29e050000@linux.dev>
Date: Mon, 28 Apr 2025 17:23:54 +0100
From: Vadim Fedorenko <vadim.fedorenko@...ux.dev>
To: Kees Cook <kees@...nel.org>, Jonathan Lemon <jonathan.lemon@...il.com>
Cc: Richard Cochran <richardcochran@...il.com>,
 Andrew Lunn <andrew+netdev@...n.ch>, "David S. Miller"
 <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
 Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
 netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-hardening@...r.kernel.org
Subject: Re: [PATCH] ptp: ocp: Add const to bp->attr_group allocation type

On 26/04/2025 07:18, Kees Cook wrote:
> In preparation for making the kmalloc family of allocators type aware,
> we need to make sure that the returned type from the allocation matches
> the type of the variable being assigned. (Before, the allocator would
> always return "void *", which can be implicitly cast to any pointer type.)
> 
> The assigned type is "const struct attribute_group **", but the returned
> type, while technically matching, will be not const qualified. As there is
> no general way to safely add const qualifiers, adjust the allocation type
> to match the assignment.
> 
> Signed-off-by: Kees Cook <kees@...nel.org>
> ---
> Cc: Jonathan Lemon <jonathan.lemon@...il.com>
> Cc: Vadim Fedorenko <vadim.fedorenko@...ux.dev>
> Cc: Richard Cochran <richardcochran@...il.com>
> Cc: Andrew Lunn <andrew+netdev@...n.ch>
> Cc: "David S. Miller" <davem@...emloft.net>
> Cc: Eric Dumazet <edumazet@...gle.com>
> Cc: Jakub Kicinski <kuba@...nel.org>
> Cc: Paolo Abeni <pabeni@...hat.com>
> Cc: <netdev@...r.kernel.org>
> ---
>   drivers/ptp/ptp_ocp.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/ptp/ptp_ocp.c b/drivers/ptp/ptp_ocp.c
> index faf6e027f89a..ed5968a3ea5a 100644
> --- a/drivers/ptp/ptp_ocp.c
> +++ b/drivers/ptp/ptp_ocp.c
> @@ -2372,7 +2372,7 @@ ptp_ocp_attr_group_add(struct ptp_ocp *bp,
>   		if (attr_tbl[i].cap & bp->fw_cap)
>   			count++;
>   
> -	bp->attr_group = kcalloc(count + 1, sizeof(struct attribute_group *),
> +	bp->attr_group = kcalloc(count + 1, sizeof(*bp->attr_group),
>   				 GFP_KERNEL);
>   	if (!bp->attr_group)
>   		return -ENOMEM;

Thanks,

Reviewed-by: Vadim Fedorenko <vadim.fedorenko@...ux.dev>