linux-kernel - Re: [Intel-wired-lan] [PATCH] e1000e: disregard NVM checksum on tgp when valid checksum mask is not set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <a0069d48-38b9-4bf0-979f-7051f8e906f4@jacekk.info>
Date: Mon, 28 Apr 2025 18:43:18 +0200
From: Jacek Kowalski <jacek@...ekk.info>
To: "Lifshits, Vitaly" <vitaly.lifshits@...el.com>,
 Simon Horman <horms@...nel.org>
Cc: Tony Nguyen <anthony.l.nguyen@...el.com>,
 Przemek Kitszel <przemyslaw.kitszel@...el.com>,
 Andrew Lunn <andrew+netdev@...n.ch>, "David S. Miller"
 <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
 Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
 intel-wired-lan@...ts.osuosl.org, netdev@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [Intel-wired-lan] [PATCH] e1000e: disregard NVM checksum on tgp
 when valid checksum mask is not set

> Anyway, I think that the commit message should be precise.
> How about this?
> 
> Starting from Tiger Lake, LAN NVM is locked for writes by SW, so the 
> driver cannot perform checksum validation and correction. This means 
> that all NVM images must leave the factory with correct checksum and 
> checksum valid bit set. Since Tiger Lake devices were the first to have 
> this lock, some systems in the field did not meet this requirement. 
> Therefore, for these transitional devices we skip checksum update and 
> verification, if the valid bit is not set.

Should I prepare v2 with this description?

-- 
Best regards,
   Jacek Kowalski