linux-kernel - Re: [PATCH] ASoC: SOF: topology: check if machine is NULL during tplg load

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAEnQRZByMFrDoPsQ+aoqfS7+1eDuiLGZYYywf+Cn=hGjRm-BzA@mail.gmail.com>
Date: Mon, 28 Apr 2025 19:50:10 +0300
From: Daniel Baluta <daniel.baluta@...il.com>
To: Laurentiu Mihalcea <laurentiumihalcea111@...il.com>, julien.massot@...labora.com
Cc: Liam Girdwood <lgirdwood@...il.com>, Peter Ujfalusi <peter.ujfalusi@...ux.intel.com>, 
	Bard Liao <yung-chuan.liao@...ux.intel.com>, 
	Ranjani Sridharan <ranjani.sridharan@...ux.intel.com>, Daniel Baluta <daniel.baluta@....com>, 
	Mark Brown <broonie@...nel.org>, Kai Vehmanen <kai.vehmanen@...ux.intel.com>, 
	Pierre-Louis Bossart <pierre-louis.bossart@...ux.dev>, linux-sound@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ASoC: SOF: topology: check if machine is NULL during tplg load

On Mon, Apr 28, 2025 at 7:16 PM Laurentiu Mihalcea
<laurentiumihalcea111@...il.com> wrote:
>
> From: Laurentiu Mihalcea <laurentiu.mihalcea@....com>
>
> Check if "sof_pdata->machine" is NULL before calling the machine-specific
> "get_function_tplg_files()". Otherwise, for OF-based machines (which set
> the "of_machine" instead of the "machine" field), the operation will
> result in a NULL pointer dereference fault.
>
> Fixes: 6d5997c412cc ("ASoC: SOF: topology: load multiple topologies")
> Signed-off-by: Laurentiu Mihalcea <laurentiu.mihalcea@....com>

Reviewed-by: Daniel Baluta <daniel.baluta@....com>

I think same patch was sent by Julien, but this one has better explanation.

Julien, I think you can add your S-o-B tag here.

Thanks,
Daniel.