linux-kernel - Re: [PATCH] drm/bridge: ti-sn65dsi86: Add necessary DSI flags

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAD=FV=WqKawr-e4riTPYfaOOW=pfsFQ9emQSqr=OB=hYNV9EQg@mail.gmail.com>
Date: Mon, 28 Apr 2025 10:00:21 -0700
From: Doug Anderson <dianders@...omium.org>
To: Jayesh Choudhary <j-choudhary@...com>
Cc: andrzej.hajda@...el.com, neil.armstrong@...aro.org, rfoss@...nel.org, 
	Laurent.pinchart@...asonboard.com, dri-devel@...ts.freedesktop.org, 
	jonas@...boo.se, jernej.skrabec@...il.com, maarten.lankhorst@...ux.intel.com, 
	mripard@...nel.org, tzimmermann@...e.de, airlied@...il.com, simona@...ll.ch, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drm/bridge: ti-sn65dsi86: Add necessary DSI flags

Hi,

On Thu, Apr 24, 2025 at 3:47 AM Jayesh Choudhary <j-choudhary@...com> wrote:
>
> Hello Doug,
>
> On 17/04/25 02:40, Jayesh Choudhary wrote:
> > Hello Doug,
> >
> > On 13/04/25 07:22, Doug Anderson wrote:
> >> Hi,
> >>
> >> On Fri, Apr 11, 2025 at 2:23 AM Jayesh Choudhary <j-choudhary@...com>
> >> wrote:
> >>>
> >>> Enable NO_EOT and SYNC flags for DSI to use VIDEO_SYNC_PULSE_MODE
> >>> with EOT disabled.
> >>
> >> Any chance you could add some details to this commit message? Your
> >> subject says that these flags are "necessary", but people have been
> >> using this driver successfully for many years now. Why did these flags
> >> suddenly become necessary and why were things working before?
> >>
> >> I'm not saying that we shouldn't use these flags, just trying to
> >> understand. I actually don't know a ton about these details in MIPI,
> >> so it would help me :-).
> >>
> >
> > Definitely.
> > I will add more details for the commit message.
> >
> > For more context here, I was working with cadence dsi driver for TI
> > SoCs. So to be more accurate, this is required for CDNS_DSI
> >
> > I observed other bridges like lt-9211, where I have seen such flags
> > being set for dsi-controller by vendors.
>
> Upon testing with modes other than video sync pulse mode,
> I found that with the upcoming fixes in cdns-dsi-core driver made by
> Tomi[0], this patch is no longer necessary.
>
> [0]:
> https://lore.kernel.org/all/20250414-cdns-dsi-impro-v3-0-4e52551d4f07@ideasonboard.com/
>
> I apologies for the noise in the mailing list.

No worries. If folks are convinced that adding these flags makes
things "more correct" I still don't have an objection to landing the
patch, though the commit message would still need to be clear about
why these flags make things more correct. I'll leave it up to you. ;-)

-Doug