linux-kernel - Re: [PATCH 5/6] x86/vdso: Use CFI macros in __vdso_sgx_enter

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <btzpfx5l43y5sp2j6zco4yh74g6zafo3jtmqumbjggjrwcoscn@vaorx7xtcmye>
Date: Mon, 28 Apr 2025 10:10:52 -0700
From: Josh Poimboeuf <jpoimboe@...nel.org>
To: Indu Bhagat <indu.bhagat@...cle.com>
Cc: Steven Rostedt <rostedt@...dmis.org>, linux-kernel@...r.kernel.org, 
	linux-trace-kernel@...r.kernel.org, Masami Hiramatsu <mhiramat@...nel.org>, 
	Mark Rutland <mark.rutland@....com>, Mathieu Desnoyers <mathieu.desnoyers@...icios.com>, 
	Andrew Morton <akpm@...ux-foundation.org>, Jens Remus <jremus@...ux.ibm.com>, x86@...nel.org, 
	Peter Zijlstra <peterz@...radead.org>, Ingo Molnar <mingo@...nel.org>, 
	Andy Lutomirski <luto@...nel.org>, Thomas Gleixner <tglx@...utronix.de>, 
	Borislav Petkov <bp@...en8.de>, Dave Hansen <dave.hansen@...ux.intel.com>, 
	"H. Peter Anvin" <hpa@...or.com>
Subject: Re: [PATCH 5/6] x86/vdso: Use CFI macros in
 __vdso_sgx_enter_enclave()

On Mon, Apr 28, 2025 at 09:17:01AM -0700, Josh Poimboeuf wrote:
> On Fri, Apr 25, 2025 at 04:22:22PM -0700, Indu Bhagat wrote:
> > On 4/24/25 7:37 PM, Steven Rostedt wrote:
> > > From: Josh Poimboeuf <jpoimboe@...nel.org>
> > > 
> > > Use the CFI macros instead of the raw .cfi_* directives to be consistent
> > > with the rest of the VDSO asm.  It's also easier on the eyes.
> > > 
> > > No functional changes.
> > > 
> > 
> > Although unrelated to the current intent of the patch, a question:
> > 
> >   Why does the stub after .Linvoke_userspace_handler in vsgs.S not have CFI
> > directives ?
> 
> Yeah, looks like that stack alignment code needs some CFI.

Actually, this function uses a frame pointer so I think the stack
pointer alignment shouldn't affect the CFI?

-- 
Josh