linux-kernel - Re: [PATCH] drm/amdgpu/userq: fix user

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CADnq5_ONJ0wyExs33aSt_jWZQ9RmL2q=nE6OkzN_4HoS3vZ9+w@mail.gmail.com>
Date: Mon, 28 Apr 2025 13:26:41 -0400
From: Alex Deucher <alexdeucher@...il.com>
To: Bagas Sanjaya <bagasdotme@...il.com>
Cc: Linux Kernel Mailing List <linux-kernel@...r.kernel.org>, 
	Linux Documentation <linux-doc@...r.kernel.org>, Linux AMDGPU <amd-gfx@...ts.freedesktop.org>, 
	Linux DRI Development <dri-devel@...ts.freedesktop.org>, Alex Deucher <alexander.deucher@....com>, 
	Christian König <christian.koenig@....com>, 
	David Airlie <airlied@...il.com>, Simona Vetter <simona@...ll.ch>, Lijo Lazar <lijo.lazar@....com>, 
	Mario Limonciello <mario.limonciello@....com>, Marek Olšák <marek.olsak@....com>, 
	Thomas Zimmermann <tzimmermann@...e.de>, Ramesh Errabolu <Ramesh.Errabolu@....com>, 
	Arvind Yadav <Arvind.Yadav@....com>, Sunil Khatri <sunil.khatri@....com>, 
	Stephen Rothwell <sfr@...b.auug.org.au>
Subject: Re: [PATCH] drm/amdgpu/userq: fix user_queue parameters list

Applied.  Thanks.

Alex

On Sat, Apr 26, 2025 at 10:37 PM Bagas Sanjaya <bagasdotme@...il.com> wrote:
>
> Sphinx reports htmldocs warning:
>
> Documentation/gpu/amdgpu/module-parameters:7: drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c:1119: ERROR: Unexpected indentation. [docutils]
>
> Fix the warning by using reST bullet list syntax for user_queue
> parameter options, separated from preceding paragraph by a blank
> line.
>
> Fixes: fb20954c9717 ("drm/amdgpu/userq: rework driver parameter")
> Reported-by: Stephen Rothwell <sfr@...b.auug.org.au>
> Closes: https://lore.kernel.org/linux-next/20250422202956.176fb590@canb.auug.org.au/
> Signed-off-by: Bagas Sanjaya <bagasdotme@...il.com>
> ---
>  drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 11 ++++++-----
>  1 file changed, 6 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
> index b9a1ef343c79cf..ec8057597c5aad 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
> @@ -1115,11 +1115,12 @@ module_param_named(rebar, amdgpu_rebar, int, 0444);
>
>  /**
>   * DOC: user_queue (int)
> - * Enable user queues on systems that support user queues.
> - * -1 = auto (ASIC specific default)
> - *  0 = user queues disabled
> - *  1 = user queues enabled and kernel queues enabled (if supported)
> - *  2 = user queues enabled and kernel queues disabled
> + * Enable user queues on systems that support user queues. Possible values:
> + *
> + * - -1 = auto (ASIC specific default)
> + * -  0 = user queues disabled
> + * -  1 = user queues enabled and kernel queues enabled (if supported)
> + * -  2 = user queues enabled and kernel queues disabled
>   */
>  MODULE_PARM_DESC(user_queue, "Enable user queues (-1 = auto (default), 0 = disable, 1 = enable, 2 = enable UQs and disable KQs)");
>  module_param_named(user_queue, amdgpu_user_queue, int, 0444);
>
> base-commit: 127e612bf16726620e431b6e0f771424916492be
> --
> An old man doll... just what I always wanted! - Clara
>