[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20250428173933.27454-1-trannamatk@gmail.com>
Date: Tue, 29 Apr 2025 00:39:33 +0700
From: Nam Tran <trannamatk@...il.com>
To: rdunlap@...radead.org
Cc: andy@...nel.org,
geert@...ux-m68k.org,
robh@...nel.org,
krzk+dt@...nel.org,
conor+dt@...nel.org,
christophe.jaillet@...adoo.fr,
corbet@....net,
devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org,
linux-doc@...r.kernel.org,
florian.fainelli@...adcom.com,
bcm-kernel-feedback-list@...adcom.com,
linux-rpi-kernel@...ts.infradead.org,
linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v8 2/5] auxdisplay: add TI LP5812 4×3 Matrix RGB LED Driver
On Sun, 27 Apr 2025 Randy Dunlap wrote:
> Hi--
>
> On 4/27/25 1:24 AM, Nam Tran wrote:
> > diff --git a/drivers/auxdisplay/Kconfig b/drivers/auxdisplay/Kconfig
> > index bedc6133f970..896f02b9a06b 100644
> > --- a/drivers/auxdisplay/Kconfig
> > +++ b/drivers/auxdisplay/Kconfig
> > @@ -539,6 +539,23 @@ config ARM_CHARLCD
> > line and the Linux version on the second line, but that's
> > still useful.
> >
> > +#
> > +# TI LP5812 matrix RGB LED driver section
> > +#
> > +config LP5812
>
> Missing one tab of indentation on all lines below here:
>
> > +tristate "Enable LP5812 support LED matrix 4x3"
> > +depends on I2C
> > +help
> > + If you say Y here you get support for TI LP5812 LED driver.
> > +
> > + The LP5812 is a 4 × 3 matrix RGB LED driver with autonomous
> > + animation engine control.
> > +
> > + To compile this driver as a module, choose M here: the
> > + module will be called lp5812.
> > +
> > + If unsure, say N.
> > +
> > endif # AUXDISPLAY
Thank you for pointing that out.
It was my mistake, and I’ll correct it.
Best regards,
Nam Tran
Powered by blists - more mailing lists