linux-kernel - Re: [PATCH v3 01/11] Revert "dt-bindings: mfd: syscon: Add qcom,apq8064-mmss-sfpb"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <676324e0-43a7-4227-8b6f-3fec97a484b0@kernel.org>
Date: Mon, 28 Apr 2025 19:50:04 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Dmitry Baryshkov <dmitry.baryshkov@....qualcomm.com>
Cc: Bjorn Andersson <andersson@...nel.org>,
 Konrad Dybcio <konradybcio@...nel.org>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Georgi Djakov <djakov@...nel.org>,
 Lee Jones <lee@...nel.org>, Suzuki K Poulose <suzuki.poulose@....com>,
 Mike Leach <mike.leach@...aro.org>, James Clark <james.clark@...aro.org>,
 Mathieu Poirier <mathieu.poirier@...aro.org>, Leo Yan <leo.yan@...ux.dev>,
 David Heidelberg <david@...t.cz>, linux-arm-msm@...r.kernel.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
 coresight@...ts.linaro.org, linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v3 01/11] Revert "dt-bindings: mfd: syscon: Add
 qcom,apq8064-mmss-sfpb"

On 28/04/2025 12:49, Dmitry Baryshkov wrote:
> On Mon, 28 Apr 2025 at 10:09, Krzysztof Kozlowski <krzk@...nel.org> wrote:
>>
>> On 28/04/2025 09:07, Krzysztof Kozlowski wrote:
>>> On Fri, Apr 25, 2025 at 08:47:01PM GMT, Dmitry Baryshkov wrote:
>>>> For some reason Lee has mis-squashed two commits, picking up one chunk
>>>> from the first patch and one chunk from the second one. Rather than
>>>> trying to fix it, revert commit 2c8de7df7418 ("dt-bindings: mfd: syscon:
>>>> Add qcom,apq8064-mmss-sfpb").
>>>
>>> I don't understand: that commit looks like direct, proper result for
>>> https://lore.kernel.org/all/20250318-fix-nexus-4-v2-5-bcedd1406790@oss.qualcomm.com/
>>> so where is squashing two commits? The diff markers have offset by few
>>> lines, but it's still just few lines and they do not matter - there is
>>> no diff/patch mismatch from that point of view.
>>
>> Ah, difference in compatibles. I see the error. Anyway, I don't think
>> revert is correct. Just add missing compatibles.
> 
> Why? The commit that went in is invalid, didn't come from my patches
> and was produced in some weird way.
And revert is pointless if you immediately add the same changes. Just
make the changes.

When we see a bug, we do not revert the feature and then re-add that
feature corrected.

Instead we correct the feature.

Best regards,
Krzysztof