linux-kernel - Re: [PATCH] KVM: Fix obsolete comment about locking for kvm_io_bus

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aA_EY8CR2kxi3X5T@google.com>
Date: Mon, 28 Apr 2025 11:09:39 -0700
From: Sean Christopherson <seanjc@...gle.com>
To: Li RongQing <lirongqing@...du.com>
Cc: pbonzini@...hat.com, kvm@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] KVM: Fix obsolete comment about locking for kvm_io_bus_read/write

On Fri, Apr 18, 2025, Li RongQing wrote:
> Nobody is actually calling these functions with slots_lock held.
> The srcu read lock is required.

I vote to delete the comments entirely, the srcu_dereference() precisely communicates
both what is being protected, and what provides the protection.