linux-kernel - Re: [PATCH v4 00/32] Samsung S2MPG10 PMIC MFD-based drivers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <24314441936d97a1892474eacdbbd690612de265.camel@linaro.org>
Date: Mon, 28 Apr 2025 19:17:25 +0100
From: André Draszik <andre.draszik@...aro.org>
To: Alexandre Belloni <alexandre.belloni@...tlin.com>, Lee Jones
	 <lee@...nel.org>
Cc: Krzysztof Kozlowski <krzk@...nel.org>, Rob Herring <robh@...nel.org>, 
 Conor Dooley <conor+dt@...nel.org>, Sylwester Nawrocki
 <s.nawrocki@...sung.com>, Chanwoo Choi	 <cw00.choi@...sung.com>, Alim
 Akhtar <alim.akhtar@...sung.com>, Michael Turquette
 <mturquette@...libre.com>, Stephen Boyd <sboyd@...nel.org>, Russell King	
 <linux@...linux.org.uk>, Catalin Marinas <catalin.marinas@....com>, Will
 Deacon	 <will@...nel.org>, Peter Griffin <peter.griffin@...aro.org>, Tudor
 Ambarus	 <tudor.ambarus@...aro.org>, Will McVicker
 <willmcvicker@...gle.com>, 	kernel-team@...roid.com,
 linux-kernel@...r.kernel.org, 	linux-samsung-soc@...r.kernel.org,
 devicetree@...r.kernel.org, 	linux-clk@...r.kernel.org,
 linux-arm-kernel@...ts.infradead.org, 	linux-rtc@...r.kernel.org, Krzysztof
 Kozlowski <krzysztof.kozlowski@...aro.org>
Subject: Re: [PATCH v4 00/32] Samsung S2MPG10 PMIC MFD-based drivers

Hi Alexandre,

On Thu, 2025-04-17 at 17:42 +0200, Alexandre Belloni wrote:
> On 15/04/2025 17:02:12+0100, Lee Jones wrote:
> > >  drivers/mfd/Kconfig                                |  35 +-
> > >  drivers/mfd/Makefile                               |   5 +-
> > >  drivers/mfd/sec-acpm.c                             | 442 +++++++++++++++++++
> > >  drivers/mfd/sec-common.c                           | 301 +++++++++++++
> > >  drivers/mfd/sec-core.c                             | 481 ---------------------
> > >  drivers/mfd/sec-core.h                             |  23 +
> > >  drivers/mfd/sec-i2c.c                              | 239 ++++++++++
> > >  drivers/mfd/sec-irq.c                              | 460 +++++++-------------
> > 
> > >  drivers/rtc/rtc-s5m.c                              | 197 ++++++---
> > 
> > MFD parts look okay to me now.
> > 
> > With Acks from the Clk and RTC maintainers, I can merge all of the
> > driver stuff together and submit a PR for others to pull from.
> > 
> 
> I don't think the RTC part depends on the MFD one so I was going to
> apply the patches in my tree if this is fine for everyone.

RTC patch 27 does depend on the s2mpg10 mfd core driver (due to
using enums and macros introduced there).

Patches 25. 26, 28, 29, 30, 31 indeed don't strictly depend on the
MFD changes. Without patch 27 in place, patches 25 & 25 will
definitely still apply, and patches 28++ will probably apply.

If you want to take them, I can then rebase this series if you think
that's better.

I'll do whatever is preferred, just let me know :-)


Cheers,
Andre'