linux-kernel - Re: [RFC][PATCH 2/2] treewide: Have the task->flags & PF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aA_KRQQXt646y37K@slm.duckdns.org>
Date: Mon, 28 Apr 2025 08:34:45 -1000
From: Tejun Heo <tj@...nel.org>
To: Alexei Starovoitov <alexei.starovoitov@...il.com>
Cc: Kees Cook <kees@...nel.org>, Steven Rostedt <rostedt@...dmis.org>,
	LKML <linux-kernel@...r.kernel.org>,
	linux-trace-kernel <linux-trace-kernel@...r.kernel.org>,
	Masami Hiramatsu <mhiramat@...nel.org>,
	Mark Rutland <mark.rutland@....com>,
	Mathieu Desnoyers <mathieu.desnoyers@...icios.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Peter Zijlstra <peterz@...radead.org>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Ingo Molnar <mingo@...hat.com>, X86 ML <x86@...nel.org>,
	bpf <bpf@...r.kernel.org>, Julia Lawall <Julia.Lawall@...ia.fr>,
	Nicolas Palix <nicolas.palix@...g.fr>, cocci@...ia.fr
Subject: Re: [RFC][PATCH 2/2] treewide: Have the task->flags & PF_KTHREAD
 check use the helper functions

On Fri, Apr 25, 2025 at 08:22:59PM -0700, Alexei Starovoitov wrote:
> > >  tools/sched_ext/scx_central.bpf.c          |  2 +-
> > >  tools/sched_ext/scx_flatcg.bpf.c           |  2 +-
> > >  tools/sched_ext/scx_qmap.bpf.c             |  2 +-
> >
> > I think these are fine. The Makefile is pulling in standard kbuild
> > Makefiles, so I think the correct include directories (outside of
> > tools/) are being used.
> 
> I suspect they are not fine.
> I don't think they #include linux/sched.h
> I would drop them for now.

Oh, this won't work. Those get all the kernel defs from the BTF generated
vmlinux.h file which doesn't include any inline functions or macros, so
please don't include them in this conversion.

Thanks.

-- 
tejun