linux-kernel - Re: [PATCH] nfp: xsk: Adjust allocation type for nn->dp.xsk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250428200457.GN3339421@horms.kernel.org>
Date: Mon, 28 Apr 2025 21:04:57 +0100
From: Simon Horman <horms@...nel.org>
To: Kees Cook <kees@...nel.org>
Cc: Louis Peens <louis.peens@...igine.com>,
	Jakub Kicinski <kuba@...nel.org>,
	Andrew Lunn <andrew+netdev@...n.ch>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>,
	Yinjun Zhang <yinjun.zhang@...igine.com>,
	Diana Wang <na.wang@...igine.com>, oss-drivers@...igine.com,
	netdev@...r.kernel.org, Jacob Keller <jacob.e.keller@...el.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	Jinjie Ruan <ruanjinjie@...wei.com>,
	Easwar Hariharan <eahariha@...ux.microsoft.com>,
	Mohammad Heib <mheib@...hat.com>, linux-kernel@...r.kernel.org,
	linux-hardening@...r.kernel.org
Subject: Re: [PATCH] nfp: xsk: Adjust allocation type for nn->dp.xsk_pools

On Fri, Apr 25, 2025 at 11:08:42PM -0700, Kees Cook wrote:
> In preparation for making the kmalloc family of allocators type aware,
> we need to make sure that the returned type from the allocation matches
> the type of the variable being assigned. (Before, the allocator would
> always return "void *", which can be implicitly cast to any pointer type.)
> 
> The assigned type "struct xsk_buff_pool **", but the returned type will be
> "struct xsk_buff_pool ***". These are the same allocation size (pointer
> size), but the types don't match. Adjust the allocation type to match
> the assignment.
> 
> Signed-off-by: Kees Cook <kees@...nel.org>

Reviewed-by: Simon Horman <horms@...nel.org>