linux-kernel - Re: [PATCH v2 2/4] media: rcar-vin: Remove unnecessary checks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250428230254.GC1969140@ragnatech.se>
Date: Tue, 29 Apr 2025 01:02:54 +0200
From: Niklas Söderlund <niklas.soderlund@...natech.se>
To: Tomi Valkeinen <tomi.valkeinen+renesas@...asonboard.com>
Cc: Mauro Carvalho Chehab <mchehab@...nel.org>,
	Sakari Ailus <sakari.ailus@...ux.intel.com>,
	linux-media@...r.kernel.org, linux-renesas-soc@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	Mauro Carvalho Chehab <mchehab+huawei@...nel.org>
Subject: Re: [PATCH v2 2/4] media: rcar-vin: Remove unnecessary checks

Hi Tomi,

Thanks for your patch.

On 2025-04-24 10:05:34 +0300, Tomi Valkeinen wrote:
> Remove unnecessary checks wrt. formats and interfaces in rvin_setup().
> The validity of the formats has already been checked earlier.
> 
> Signed-off-by: Tomi Valkeinen <tomi.valkeinen+renesas@...asonboard.com>

Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@...natech.se>
Tested-by: Niklas Söderlund <niklas.soderlund+renesas@...natech.se>

> ---
>  drivers/media/platform/renesas/rcar-vin/rcar-dma.c | 23 ----------------------
>  1 file changed, 23 deletions(-)
> 
> diff --git a/drivers/media/platform/renesas/rcar-vin/rcar-dma.c b/drivers/media/platform/renesas/rcar-vin/rcar-dma.c
> index 972ae2cb3314..0b5077e2e989 100644
> --- a/drivers/media/platform/renesas/rcar-vin/rcar-dma.c
> +++ b/drivers/media/platform/renesas/rcar-vin/rcar-dma.c
> @@ -802,29 +802,6 @@ static int rvin_setup(struct rvin_dev *vin)
>  		break;
>  	}
>  
> -	/* Make sure input interface and input format is valid. */
> -	if (vin->info->model == RCAR_GEN3 || vin->info->model == RCAR_GEN4) {
> -		switch (vnmc & VNMC_INF_MASK) {
> -		case VNMC_INF_YUV8_BT656:
> -		case VNMC_INF_YUV10_BT656:
> -		case VNMC_INF_YUV16:
> -		case VNMC_INF_RGB666:
> -			if (vin->is_csi) {
> -				vin_err(vin, "Invalid setting in MIPI CSI2\n");
> -				return -EINVAL;
> -			}
> -			break;
> -		case VNMC_INF_RAW8:
> -			if (!vin->is_csi) {
> -				vin_err(vin, "Invalid setting in Digital Pins\n");
> -				return -EINVAL;
> -			}
> -			break;
> -		default:
> -			break;
> -		}
> -	}
> -
>  	/* Enable VSYNC Field Toggle mode after one VSYNC input */
>  	if (vin->info->model == RCAR_GEN3 || vin->info->model == RCAR_GEN4)
>  		dmr2 = VNDMR2_FTEV;
> 
> -- 
> 2.43.0
> 

-- 
Kind Regards,
Niklas Söderlund