linux-kernel - Re: [PATCH v2 3/3] alarmtimer: switch some spin_{lock,unlock}

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANDhNCpg0WRm6=7cb2pTqNswCE=3__7k6oFeGKKuZD7oQ_rmkg@mail.gmail.com>
Date: Mon, 28 Apr 2025 16:05:32 -0700
From: John Stultz <jstultz@...gle.com>
To: Su Hui <suhui@...china.com>
Cc: tglx@...utronix.de, sboyd@...nel.org, dan.carpenter@...aro.org, 
	linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH v2 3/3] alarmtimer: switch some spin_{lock,unlock}_irqsave()
 to guard()

On Sun, Apr 27, 2025 at 4:35 AM Su Hui <suhui@...china.com> wrote:
>
> Using guard/scoped_guard() to simplify code. Using guard() to remove
> 'goto unlock' label is neater especially.
>
> Signed-off-by: Su Hui <suhui@...china.com>
> ---
> v2:
>  - Remove some guard() usages acrodding to john's suggestions.
>
>  kernel/time/alarmtimer.c | 56 +++++++++++++++++-----------------------
>  1 file changed, 23 insertions(+), 33 deletions(-)

Looks ok to me.
Acked-by: John Stultz <jstultz@...gle.com>

thanks!
-john