linux-kernel - Re: [PATCH 5/5] dt-bindings: hwmon: Add bindings for mpq8785 driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <174588281340.1841112.12342859635067816713.robh@kernel.org>
Date: Mon, 28 Apr 2025 18:26:53 -0500
From: "Rob Herring (Arm)" <robh@...nel.org>
To: Pawel Dembicki <paweldembicki@...il.com>
Cc: devicetree@...r.kernel.org, 
 Uwe Kleine-König <u.kleine-koenig@...gutronix.de>, 
 Jean Delvare <jdelvare@...e.com>, Charles Hsu <ythsu0511@...il.com>, 
 linux-hwmon@...r.kernel.org, Krzysztof Kozlowski <krzk+dt@...nel.org>, 
 Greg KH <gregkh@...uxfoundation.org>, Conor Dooley <conor+dt@...nel.org>, 
 linux-kernel@...r.kernel.org, Peter Zijlstra <peterz@...radead.org>, 
 Jonathan Corbet <corbet@....net>, linux-doc@...r.kernel.org, 
 Guenter Roeck <linux@...ck-us.net>, Shen Lichuan <shenlichuan@...o.com>
Subject: Re: [PATCH 5/5] dt-bindings: hwmon: Add bindings for mpq8785
 driver


On Tue, 29 Apr 2025 00:13:35 +0200, Pawel Dembicki wrote:
> Add device tree bindings for Monolithic Power Systems MPQ8785, MPM82504
> and MPM3695 PMBus-compliant voltage regulators.
> 
> These bindings also documents the optional "voltage-scale-loop" property.
> 
> Signed-off-by: Pawel Dembicki <paweldembicki@...il.com>
> ---
>  .../bindings/hwmon/pmbus/mps,mpq8785.yaml     | 54 +++++++++++++++++++
>  1 file changed, 54 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/hwmon/pmbus/mps,mpq8785.yaml
> 

My bot found errors running 'make dt_binding_check' on your patch:

yamllint warnings/errors:

dtschema/dtc warnings/errors:
Warning: Duplicate compatible "mps,mpq8785" found in schemas matching "$id":
	http://devicetree.org/schemas/hwmon/pmbus/mps,mpq8785.yaml#
	http://devicetree.org/schemas/trivial-devices.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/hwmon/pmbus/mps,mpq8785.example.dtb: pmic@30 (mps,mpm82504): False schema does not allow {'compatible': ['mps,mpm82504'], 'reg': [[48]], 'voltage-scale-loop': 600, '$nodename': ['pmic@30']}
	from schema $id: http://devicetree.org/schemas/hwmon/pmbus/mps,mpq8785.yaml#

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20250428221420.2077697-6-paweldembicki@gmail.com

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.