linux-kernel - Re: (subset) [PATCH 0/2] power: supply: max77705: Fix two static checker issues

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <x73k5kkoforly65u7dfdbpqi2miutdierhyta5i2x6l4akijsd@fnxxjjm7m466>
Date: Tue, 29 Apr 2025 01:30:16 +0200
From: Sebastian Reichel <sebastian.reichel@...labora.com>
To: Dzmitry Sankouski <dsankouski@...il.com>, 
	Dan Carpenter <dan.carpenter@...aro.org>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>, 
	Lee Jones <lee@...nel.org>, linux-kernel@...r.kernel.org, linux-pm@...r.kernel.org
Subject: Re: (subset) [PATCH 0/2] power: supply: max77705: Fix two static
 checker issues

Hi,

On Tue, Apr 29, 2025 at 12:18:43AM +0200, Sebastian Reichel wrote:
> On Fri, 21 Mar 2025 17:34:00 +0300, Dan Carpenter wrote:
> > Fix some error handling and an error code bug.
> > 
> > Dan Carpenter (2):
> >   power: supply: max77705: Fix workqueue error handling in probe
> >   power: supply: max77705: Fix error code in max77705_get_health()
> > 
> > drivers/power/supply/max77705_charger.c | 22 +++++++++++++++-------
> >  1 file changed, 15 insertions(+), 7 deletions(-)
> > 
> > [...]
> 
> Applied, thanks!
> 
> [1/2] power: supply: max77705: Fix workqueue error handling in probe
>       commit: 11741b8e382d34b13277497ab91123d8b0b5c2db

I've queued it, since it improves the driver. But the workqueue also
needs to be released when the module is removed. So I think the
destroy_workqueue() should happen via devm_add_action_or_reset()
instead of what this patch is doing.

Greetings,

-- Sebastian

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)