linux-kernel - Re: [PATCH v3] serdev: Refine several error or debug messages

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ac37802c-65d3-48b8-9d98-fde35986692a@kernel.org>
Date: Mon, 28 Apr 2025 07:32:45 +0200
From: Jiri Slaby <jirislaby@...nel.org>
To: Zijun Hu <zijun_hu@...oud.com>, Rob Herring <robh@...nel.org>,
 Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc: linux-serial@...r.kernel.org, linux-kernel@...r.kernel.org,
 Zijun Hu <quic_zijuhu@...cinc.com>
Subject: Re: [PATCH v3] serdev: Refine several error or debug messages

On 25. 04. 25, 14:48, Zijun Hu wrote:
> From: Zijun Hu <quic_zijuhu@...cinc.com>
> 
> Refine several dev_err() and dev_dbg() messages to solve:
> 
> // hardcoded device name
> dev_dbg(dev, "...dev_name_str...")
> 
> // repeated device name since dev_dbg() also prints it as prefix
> dev_err(dev, "...%s...", dev_name(dev))
> 
> // not concise as dev_err(dev, "...%d...", err)
> dev_err(dev, "...%pe...", ERR_PTR(err))
> 
> Signed-off-by: Zijun Hu <quic_zijuhu@...cinc.com>

This LGTM.

Reviewed-by: Jiri Slaby <jirislaby@...nel.org>


-- 
js
suse labs