linux-kernel - Re: [PATCH 2/6] btrfs: drop usage of folio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aA7OC1d0L1lgZ557@casper.infradead.org>
Date: Mon, 28 Apr 2025 01:38:35 +0100
From: Matthew Wilcox <willy@...radead.org>
To: Kairui Song <kasong@...cent.com>
Cc: linux-mm@...ck.org, Andrew Morton <akpm@...ux-foundation.org>,
	David Hildenbrand <david@...hat.com>,
	Hugh Dickins <hughd@...gle.com>, Chris Li <chrisl@...nel.org>,
	Yosry Ahmed <yosryahmed@...gle.com>,
	"Huang, Ying" <ying.huang@...ux.alibaba.com>,
	Nhat Pham <nphamcs@...il.com>, Johannes Weiner <hannes@...xchg.org>,
	linux-kernel@...r.kernel.org, Chris Mason <clm@...com>,
	Josef Bacik <josef@...icpanda.com>, David Sterba <dsterba@...e.com>,
	linux-btrfs@...r.kernel.org
Subject: Re: [PATCH 2/6] btrfs: drop usage of folio_index

On Mon, Apr 28, 2025 at 02:59:04AM +0800, Kairui Song wrote:
> From: Kairui Song <kasong@...cent.com>
> 
> folio_index is only needed for mixed usage of page cache and swap
> cache, for pure page cache usage, the caller can just use
> folio->index instead.
> 
> It can't be a swap cache folio here.  Swap mapping may only call into fs
> through `swap_rw` and that is not supported for btrfs.  So just drop it
> and use folio->index instead.
> 
> Signed-off-by: Kairui Song <kasong@...cent.com>
> Cc: Chris Mason <clm@...com> (maintainer:BTRFS FILE SYSTEM)
> Cc: Josef Bacik <josef@...icpanda.com> (maintainer:BTRFS FILE SYSTEM)
> Cc: David Sterba <dsterba@...e.com> (maintainer:BTRFS FILE SYSTEM)
> Cc: linux-btrfs@...r.kernel.org (open list:BTRFS FILE SYSTEM)
> Signed-off-by: Kairui Song <kasong@...cent.com>

Reviewed-by: Matthew Wilcox (Oracle) <willy@...radead.org>