linux-kernel - Re: [PATCH v6 09/11] iio: adc: ad7768-1: replace manual attribute declaration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAHp75Vc2AN0_KBDj--eaFYsQBzFJYiReXfweasuyntxdkP1Xhg@mail.gmail.com>
Date: Mon, 28 Apr 2025 10:10:05 +0300
From: Andy Shevchenko <andy.shevchenko@...il.com>
To: Jonathan Santos <Jonathan.Santos@...log.com>
Cc: linux-iio@...r.kernel.org, devicetree@...r.kernel.org, 
	linux-kernel@...r.kernel.org, linux-gpio@...r.kernel.org, andy@...nel.org, 
	nuno.sa@...log.com, Michael.Hennerich@...log.com, marcelo.schmitt@...log.com, 
	jic23@...nel.org, robh@...nel.org, krzk+dt@...nel.org, conor+dt@...nel.org, 
	marcelo.schmitt1@...il.com, linus.walleij@...aro.org, brgl@...ev.pl, 
	lgirdwood@...il.com, broonie@...nel.org, jonath4nns@...il.com, 
	dlechner@...libre.com
Subject: Re: [PATCH v6 09/11] iio: adc: ad7768-1: replace manual attribute declaration

On Mon, Apr 28, 2025 at 3:14 AM Jonathan Santos
<Jonathan.Santos@...log.com> wrote:
>
> Use read_avail callback from struct iio_info to replace the manual
> declaration of sampling_frequency_available attribute.

...

> +static void ad7768_fill_samp_freq_tbl(struct ad7768_state *st)
> +{
> +       int i;

Why signed?

> +       for (i = 0; i < ARRAY_SIZE(ad7768_clk_config); i++)

Check that the driver includes array_size.h...

> +               st->samp_freq_avail[i] = DIV_ROUND_CLOSEST(st->mclk_freq,
> +                                                          ad7768_clk_config[i].clk_div);

...and math.h.

> +}

-- 
With Best Regards,
Andy Shevchenko