linux-kernel - Re: linux-next: build failure after merge of the tip tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250428171852.36d8533a@canb.auug.org.au>
Date: Mon, 28 Apr 2025 17:18:52 +1000
From: Stephen Rothwell <sfr@...b.auug.org.au>
To: Ingo Molnar <mingo@...hat.com>, Arnaldo Carvalho de Melo
 <acme@...nel.org>
Cc: Athira Rajeev <atrajeev@...ux.ibm.com>, Shrikanth Hegde
 <sshegde@...ux.ibm.com>, Venkat Rao Bagalkote <venkat88@...ux.ibm.com>,
 Linux Kernel Mailing List <linux-kernel@...r.kernel.org>, Linux Next
 Mailing List <linux-next@...r.kernel.org>, Thomas Gleixner
 <tglx@...utronix.de>, "H. Peter Anvin" <hpa@...or.com>, Peter Zijlstra
 <peterz@...radead.org>, Namhyung Kim <namhyung@...nel.org>
Subject: Re: linux-next: build failure after merge of the tip tree

Hi all,

On Thu, 24 Apr 2025 22:03:05 +0530 Athira Rajeev <atrajeev@...ux.ibm.com> wrote:
>
> > On 24 Apr 2025, at 8:07 PM, Athira Rajeev <atrajeev@...ux.ibm.com> wrote:
> >   
> >> On 22 Apr 2025, at 3:26 PM, Shrikanth Hegde <sshegde@...ux.ibm.com> wrote:
> >> 
> >> On 4/22/25 12:05, Stephen Rothwell wrote:  
> >>   
> >>> On Thu, 17 Apr 2025 13:49:59 +1000 Stephen Rothwell <sfr@...b.auug.org.au> wrote:  
> >>>> 
> >>>> On Tue, 15 Apr 2025 13:35:18 +1000 Stephen Rothwell <sfr@...b.auug.org.au> wrote:  
> >>>>> 
> >>>>> After merging the tip tree, today's linux-next build (native perf)
> >>>>> failed like this:
> >>>>> 
> >>>>> diff: tools/arch/x86/include/asm/amd/ibs.h: No such file or directory
> >>>>> In file included from util/amd-sample-raw.c:12:
> >>>>> tools/include/../../arch/x86/include/asm/amd/ibs.h:10:10: fatal error: asm/msr-index.h: No such file or directory
> >>>>>   10 | #include <asm/msr-index.h>
> >>>>>      |          ^~~~~~~~~~~~~~~~~
> >>>>> compilation terminated.
> >>>>> 
> >>>>> Maybe caused by commit
> >>>>> 
> >>>>>  3846389c03a8 ("x86/platform/amd: Move the <asm/amd-ibs.h> header to <asm/amd/ibs.h>")
> >>>>> or associated commits?
>
> Posted the fix in mailing here: https://lore.kernel.org/linux-perf-users/20250424163033.6601-1-atrajeev@linux.ibm.com/T/#u
> Please share feedback if it fixes the compilation issue.

OK, so to progress things ...

Just reverting the changes to tools/perf in commit

  3846389c03a8 ("x86/platform/amd: Move the <asm/amd-ibs.h> header to <asm/amd/ibs.h>")

Allows perf to build again on ppc64el (and gets rid of the warning), so
is that a reasonable thing to do - and leave the tools perf update to
the perf guys?

If so, can that partial revert be added to the tip tree, please?
-- 
Cheers,
Stephen Rothwell

Content of type "application/pgp-signature" skipped