linux-kernel - Re: [PATCH 2/3] mm/debug_page_alloc: improve error message for invalid guardpage minorder

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0c2a0d93-bde9-48ec-bfb4-0a0747857f7e@redhat.com>
Date: Mon, 28 Apr 2025 09:21:19 +0200
From: David Hildenbrand <david@...hat.com>
To: Ye Liu <ye.liu@...ux.dev>, akpm@...ux-foundation.org
Cc: linux-kernel@...r.kernel.org, linux-mm@...ck.org, rppt@...nel.org,
 lorenzo.stoakes@...cle.com, Liam.Howlett@...cle.com, harry.yoo@...cle.com,
 riel@...riel.com, vbabka@...e.cz, liuye@...inos.cn
Subject: Re: [PATCH 2/3] mm/debug_page_alloc: improve error message for
 invalid guardpage minorder

On 27.04.25 12:04, Ye Liu wrote:
> From: Ye Liu <liuye@...inos.cn>
> 
> When an invalid debug_guardpage_minorder value is provided, include the
> user input in the error message. This helps users and developers diagnose
> configuration issues more easily.
> 
> No functional change.
> 
> Signed-off-by: Ye Liu <liuye@...inos.cn>
> ---
>   mm/debug_page_alloc.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/mm/debug_page_alloc.c b/mm/debug_page_alloc.c
> index d46acf989dde..6a26eca546c3 100644
> --- a/mm/debug_page_alloc.c
> +++ b/mm/debug_page_alloc.c
> @@ -23,7 +23,7 @@ static int __init debug_guardpage_minorder_setup(char *buf)
>   	unsigned long res;
>   
>   	if (kstrtoul(buf, 10, &res) < 0 ||  res > MAX_PAGE_ORDER / 2) {
> -		pr_err("Bad debug_guardpage_minorder value\n");
> +		pr_err("Bad debug_guardpage_minorder value: %s\n", buf);

I would guess everybody setting that should know how to find easily out 
what they tried to set, but in any case

Acked-by: David Hildenbrand <david@...hat.com>

-- 
Cheers,

David / dhildenb