linux-kernel - Re: [PATCH v3] ata: libata: disable LPM for WDC WD20EFAX-68FB5N0 hard drives

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aA8xCLulpVz6V8T0@ryzen>
Date: Mon, 28 Apr 2025 09:40:56 +0200
From: Niklas Cassel <cassel@...nel.org>
To: Mikko Juhani Korhonen <mjkorhon@...il.com>
Cc: Damien Le Moal <dlemoal@...nel.org>, linux-ide@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3] ata: libata: disable LPM for WDC WD20EFAX-68FB5N0
 hard drives

On Fri, Apr 25, 2025 at 10:33:17PM +0300, Mikko Juhani Korhonen wrote:
> Make WDC WD20EFAX-68FB5N0 hard drives work again after regression in
> 6.9.0 when LPM was enabled, so disable it for this model.
> 
> Signed-off-by: Mikko Korhonen <mjkorhon@...il.com>
> ---
> drivers/ata/libata-core.c | 5 +++++
> 1 file changed, 5 insertions(+)
> 
> diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c
> index 773799cfd443..5c2f26945d61 100644
> --- a/drivers/ata/libata-core.c
> +++ b/drivers/ata/libata-core.c
> @@ -4239,6 +4239,11 @@ static const struct ata_dev_quirks_entry
> __ata_dev_quirks[] = {
>        { "WDC WD3000JD-*",             NULL,   ATA_QUIRK_WD_BROKEN_LPM },
>        { "WDC WD3200JD-*",             NULL,   ATA_QUIRK_WD_BROKEN_LPM },
> 
> +       /*
> +        * This specific WD SATA-3 model has problems with LPM.
> +        */
> +       { "WDC WD20EFAX-68FB5N0",       NULL,   ATA_QUIRK_NOLPM },
> +
>        /*
>         * This sata dom device goes on a walkabout when the ATA_LOG_DIRECTORY
>         * log page is accessed. Ensure we never ask for this log page with
> 
> base-commit: 14a3cc755825ef7b34c986aa2786ea815023e9c5
> --
> 2.47.2

Hello Mikko,

I tried to apply this commit, but it fails with:

Applying: ata: libata: disable LPM for WDC WD20EFAX-68FB5N0 hard drives
Patch failed at 0001 ata: libata: disable LPM for WDC WD20EFAX-68FB5N0 hard drives
error: corrupt patch at line 10


Please use:
$ git format-patch -1
You should then get a foo.patch.

You should then be able to do (locally):
$ git checkout HEAD~
$ git am foo.patch

to verify that the commit can be applied.


Kind regards,
Niklas