linux-kernel - Re: [mainline]Warning while building tools/perf

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <CAGxU2F4X2TYM+fD-TnLjTPd+AcwSccREBnO1+geSFs-KVM4kRg@mail.gmail.com>
Date: Mon, 28 Apr 2025 09:42:10 +0200
From: Stefano Garzarella <sgarzare@...hat.com>
To: Venkat Rao Bagalkote <venkat88@...ux.ibm.com>, 
	Arnaldo Carvalho de Melo <acme@...hat.com>
Cc: Namhyung Kim <namhyung@...nel.org>, 
	James Clark <james.clark@...aro.org>, Athira Rajeev <atrajeev@...ux.ibm.com>, 
	Ingo Molnar <mingo@...nel.org>, 
	"open list:PERFORMANCE EVENTS SUBSYSTEM" <linux-perf-users@...r.kernel.org>, LKML <linux-kernel@...r.kernel.org>, mst@...hat.com
Subject: Re: [mainline]Warning while building tools/perf

On Fri, 25 Apr 2025 at 18:07, Venkat Rao Bagalkote <venkat88@...ux.ibm.com> wrote:
>
>
> My bad, missed to mention the warning in the previous mail.
>
> On 25/04/25 9:32 pm, Venkat Rao Bagalkote wrote:
> > Hello,
> >
> >
> > I am seeing a new build warning while building tools/perf on the
> > mainline kernel, with base:
> >
> > commit 02ddfb981de88a2c15621115dd7be2431252c568 (HEAD -> master,
> > origin/master, origin/HEAD)
> > Merge: 30e268185e59 b0b7ee3b574a
> > Author: Linus Torvalds <torvalds@...ux-foundation.org>
> > Date:   Thu Apr 24 13:01:31 2025 -0700
> >
> >     Merge tag 'scsi-fixes' of
> > git://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi
> >
> >     Pull SCSI fixes from James Bottomley:
> >      "The single core change is an obvious bug fix (and falls within
> > the LF
> >       guidelines for patches from sanctioned entities). The other driver
> >       changes are a bit larger but likewise pretty obvious"
> >
> >     * tag 'scsi-fixes' of
> > git://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi:
> >       scsi: mpi3mr: Add level check to control event logging
> >       scsi: ufs: core: Add NULL check in
> > ufshcd_mcq_compl_pending_transfer()
> >       scsi: core: Clear flags for scsi_cmnd that did not complete
> >       scsi: ufs: Introduce quirk to extend PA_HIBERN8TIME for UFS devices
> >       scsi: ufs: qcom: Add quirks for Samsung UFS devices
> >       scsi: target: iscsi: Fix timeout on deleted connection
> >       scsi: mpi3mr: Reset the pending interrupt flag
> >       scsi: mpi3mr: Fix pending I/O counter
> >       scsi: ufs: mcq: Add NULL check in ufshcd_mcq_abort()
> >
>
> Warning:
>
> diff -u tools/perf/trace/beauty/include/uapi/linux/vhost.h
> include/uapi/linux/vhost.h
>
> >
> > Git Bisect is pointing to below commit as first bad commit.
> >
> >
> > a940e0a685575424d33324ec7f0089045249de0a is the first bad commit
> > commit a940e0a685575424d33324ec7f0089045249de0a

That commit just updated the documentation, no code change.

I guess in tools/perf they copied vhost.h and there is some check to 
control if they are in sync.

CCing Arnaldo who has updated the copy several times.

Thanks,
Stefano

> > Author: Stefano Garzarella <sgarzare@...hat.com>
> > Date:   Mon Mar 3 09:52:37 2025 +0100
> >
> >     vhost: fix VHOST_*_OWNER documentation
> >
> >     VHOST_OWNER_SET and VHOST_OWNER_RESET are used in the documentation
> >     instead of VHOST_SET_OWNER and VHOST_RESET_OWNER respectively.
> >
> >     To avoid confusion, let's use the right names in the documentation.
> >     No change to the API, only the documentation is involved.
> >
> >     Signed-off-by: Stefano Garzarella <sgarzare@...hat.com>
> >     Message-Id: <20250303085237.19990-1-sgarzare@...hat.com>
> >     Signed-off-by: Michael S. Tsirkin <mst@...hat.com>
> >
> >  include/uapi/linux/vhost.h | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> >
> > Upon reverting the above commit, warning is not seen.
> >
> >
> > Bisect log:
> >
> >
> > git bisect start
> > # status: waiting for both good and bad commits
> > # good: [9c32cda43eb78f78c73aee4aa344b777714e259b] Linux 6.15-rc3
> > git bisect good 9c32cda43eb78f78c73aee4aa344b777714e259b
> > # status: waiting for bad commit, 1 good commit known
> > # bad: [02ddfb981de88a2c15621115dd7be2431252c568] Merge tag
> > 'scsi-fixes' of git://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi
> > git bisect bad 02ddfb981de88a2c15621115dd7be2431252c568
> > # good: [cc0dec3f659d19805fcaf8822204137c9f27a912] Merge branch
> > 'net-stmmac-fix-timestamp-snapshots-on-dwmac1000'
> > git bisect good cc0dec3f659d19805fcaf8822204137c9f27a912
> > # bad: [0251ddbffbeb213f0f74ef94b2cacce580eb8d76] Merge tag
> > 'for_linus' of git://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost
> > git bisect bad 0251ddbffbeb213f0f74ef94b2cacce580eb8d76
> > # good: [bc3372351d0c8b2726b7d4229b878342e3e6b0e8] Merge tag
> > 'for-6.15-rc3-tag' of
> > git://git.kernel.org/pub/scm/linux/kernel/git/kdave/linux
> > git bisect good bc3372351d0c8b2726b7d4229b878342e3e6b0e8
> > # bad: [fbd3039a64b01b769040677c4fc68badeca8e3b2] virtio_console: fix
> > missing byte order handling for cols and rows
> > git bisect bad fbd3039a64b01b769040677c4fc68badeca8e3b2
> > # bad: [a940e0a685575424d33324ec7f0089045249de0a] vhost: fix
> > VHOST_*_OWNER documentation
> > git bisect bad a940e0a685575424d33324ec7f0089045249de0a
> > # good: [16c22c56d4282584742022a37d4f79a46ca6094a] virtio_pci: Use
> > self group type for cap commands
> > git bisect good 16c22c56d4282584742022a37d4f79a46ca6094a
> > # first bad commit: [a940e0a685575424d33324ec7f0089045249de0a] vhost:
> > fix VHOST_*_OWNER documentation
> >
> >
> > If you happen to fix this, please add below tag.
> >
> >
> > Reported-by: Venkat Rao Bagalkote <venkat88@...ux.ibm.com>
> >
> >
> > Regards,
> >
> > Venkat.
> >
>