linux-kernel - Re: [PATCH v3 3/4] tpm/tpm_ftpm_tee: support TPM_CHIP_FLAG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aA8zBP6h8oG5m4w9@sumit-X1>
Date: Mon, 28 Apr 2025 13:19:24 +0530
From: Sumit Garg <sumit.garg@...nel.org>
To: Stefano Garzarella <sgarzare@...hat.com>
Cc: Jens Wiklander <jens.wiklander@...aro.org>,
	Jarkko Sakkinen <jarkko@...nel.org>,
	Christophe Leroy <christophe.leroy@...roup.eu>,
	Peter Huewe <peterhuewe@....de>,
	Alexandre Belloni <alexandre.belloni@...tlin.com>,
	Claudiu Beznea <claudiu.beznea@...on.dev>,
	Naveen N Rao <naveen@...nel.org>,
	Nicholas Piggin <npiggin@...il.com>, linuxppc-dev@...ts.ozlabs.org,
	Nicolas Ferre <nicolas.ferre@...rochip.com>,
	Michael Ellerman <mpe@...erman.id.au>,
	Madhavan Srinivasan <maddy@...ux.ibm.com>,
	James Bottomley <James.Bottomley@...senpartnership.com>,
	linux-integrity@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
	Jason Gunthorpe <jgg@...pe.ca>
Subject: Re: [PATCH v3 3/4] tpm/tpm_ftpm_tee: support TPM_CHIP_FLAG_SYNC

On Mon, Apr 14, 2025 at 04:59:47PM +0200, Stefano Garzarella wrote:
> On Mon, 14 Apr 2025 at 16:57, Stefano Garzarella <sgarzare@...hat.com> wrote:
> >
> > From: Stefano Garzarella <sgarzare@...hat.com>
> >
> > This driver does not support interrupts, and receiving the response is
> > synchronous with sending the command.
> >
> > So we can set TPM_CHIP_FLAG_SYNC to support synchronous send() and
> > return responses in the same buffer used for commands. This way we
> > don't need the 4KB internal buffer used to cache the response before
> > .send() and .recv(). Also we don't need to implement recv() op.
> >
> > Signed-off-by: Stefano Garzarella <sgarzare@...hat.com>
> > ---
> > v2:
> > - set TPM_CHIP_FLAG_SYNC and support it in the new send()
> > - removed Jens' T-b
> 
> @Jens @Sumit can you test/review this patch again since from v1 we
> changed the core a bit adding TPM_CHIP_FLAG_SYNC instead of
> send_recv() op?

Reviewed-by: Sumit Garg <sumit.garg@....qualcomm.com>

-Sumit