linux-kernel - Re: [PATCH 6.1 000/291] 6.1.135-rc1 review

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <b3f78f39-4c64-4957-8363-5b67c19a9f1e@windriver.com>
Date: Mon, 28 Apr 2025 15:50:14 +0800
From: He Zhe <zhe.he@...driver.com>
To: Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Arnd Bergmann <arnd@...db.de>
Cc: Naresh Kamboju <naresh.kamboju@...aro.org>, stable@...r.kernel.org,
        patches@...ts.linux.dev, linux-kernel@...r.kernel.org,
        Linus Torvalds <torvalds@...ux-foundation.org>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Guenter Roeck
 <linux@...ck-us.net>, shuah <shuah@...nel.org>,
        patches@...nelci.org, lkft-triage@...ts.linaro.org,
        Pavel Machek <pavel@...x.de>, Jon Hunter <jonathanh@...dia.com>,
        Florian Fainelli <f.fainelli@...il.com>,
        Sudip Mukherjee <sudipm.mukherjee@...il.com>,
        Slade Watkins <srw@...dewatkins.net>, rwarsow@....de,
        Conor Dooley <conor@...nel.org>, hargar@...rosoft.com,
        Mark Brown <broonie@...nel.org>, Netdev <netdev@...r.kernel.org>,
        clang-built-linux <llvm@...ts.linux.dev>,
        Anders Roxell <anders.roxell@...aro.org>,
        Dan Carpenter <dan.carpenter@...aro.org>,
        Nathan Chancellor <nathan@...nel.org>,
        "David S . Miller"
 <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>
Subject: Re: [PATCH 6.1 000/291] 6.1.135-rc1 review



On 2025/4/24 23:28, Greg Kroah-Hartman wrote:
> On Thu, Apr 24, 2025 at 04:34:04PM +0200, Arnd Bergmann wrote:
>> On Thu, Apr 24, 2025, at 15:41, Greg Kroah-Hartman wrote:
>>> On Thu, Apr 24, 2025 at 07:01:02PM +0530, Naresh Kamboju wrote:
>>>> ## Build error:
>>>> net/sched/act_mirred.c:265:6: error: variable 'is_redirect' is used
>>>> uninitialized whenever 'if' condition is true
>>>> [-Werror,-Wsometimes-uninitialized]
>>>>   265 |         if (unlikely(!(dev->flags & IFF_UP)) ||
>>>> !netif_carrier_ok(dev)) {
>>>>       |             ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>>> Odd this isn't showing up in newer releases, as this is an old commit
>>> and nothing has changed in this file since then (it showed up in 6.8.)
>>>
>>> Is there some follow-up commit somewhere that I'm missing that resolved
>>> this issue?
>> I think the difference is commit 16085e48cb48 ("net/sched: act_mirred:
>> Create function tcf_mirred_to_dev and improve readability") from 
>> v6.8, which adds the initialization that 166c2c8a6a4d ("net/sched:
>> act_mirred: don't override retval if we already lost the skb")
>> relies on.
> Ok, that didn't apply cleanly either, so I'm just going to drop this
> backported patch and wait for the submitter to fix it up and resend it.

Sorry for the inconvenience. We have fixed the above issue found by clang-20
and will sent out v2 soon.

Thanks,
Zhe

>
> thanks,
>
> greg k-h