linux-kernel - RE: [PATCH v2 5/5] spi: nxp-fspi: use devm instead of remove for driver detach

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID:
 <DU0PR04MB949641E4A006431C6D68B77490812@DU0PR04MB9496.eurprd04.prod.outlook.com>
Date: Mon, 28 Apr 2025 08:20:07 +0000
From: Bough Chen <haibo.chen@....com>
To: ALOK TIWARI <alok.a.tiwari@...cle.com>, Han Xu <han.xu@....com>, Yogesh
 Gaur <yogeshgaur.83@...il.com>, Mark Brown <broonie@...nel.org>
CC: "linux-spi@...r.kernel.org" <linux-spi@...r.kernel.org>,
	"imx@...ts.linux.dev" <imx@...ts.linux.dev>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>
Subject: RE: [PATCH v2 5/5] spi: nxp-fspi: use devm instead of remove for
 driver detach

> -----Original Message-----
> From: ALOK TIWARI <alok.a.tiwari@...cle.com>
> Sent: 2025年4月26日 2:46
> To: Bough Chen <haibo.chen@....com>; Han Xu <han.xu@....com>; Yogesh
> Gaur <yogeshgaur.83@...il.com>; Mark Brown <broonie@...nel.org>
> Cc: linux-spi@...r.kernel.org; imx@...ts.linux.dev; linux-kernel@...r.kernel.org
> Subject: Re: [PATCH v2 5/5] spi: nxp-fspi: use devm instead of remove for driver
> detach
> 
> 
> 
> On 24-04-2025 13:03, Haibo Chen wrote:
> > +	/* enable clock first since there is reigster access */
> 
> typo register

Thanks, will fix in next version.

Regards
Haibo Chen
> 
> > +	pm_runtime_get_sync(f->dev);
> > +
> > +	/* disable the hardware */
> > +	fspi_writel(f, FSPI_MCR0_MDIS, f->iobase + FSPI_MCR0);
> 
> 
> Thanks,
> Alok