linux-kernel - Re: [PATCH v1 1/1] util_macros.h: Make the header more resilient

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20250428023220.7cfab2286bb94f25c6bf7ca9@linux-foundation.org>
Date: Mon, 28 Apr 2025 02:32:20 -0700
From: Andrew Morton <akpm@...ux-foundation.org>
To: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc: Alexandru Ardelean <aardelean@...libre.com>,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1 1/1] util_macros.h: Make the header more resilient

On Mon, 28 Apr 2025 10:27:54 +0300 Andy Shevchenko <andriy.shevchenko@...ux.intel.com> wrote:

> Add missing header inclusions and protect against double inclusion.

The patch doesn't "protect against double inclusion"?

> --- a/include/linux/util_macros.h
> +++ b/include/linux/util_macros.h
> @@ -2,7 +2,10 @@
>  #ifndef _LINUX_HELPER_MACROS_H_
>  #define _LINUX_HELPER_MACROS_H_
>  
> +#include <linux/compiler_attributes.h>
>  #include <linux/math.h>
> +#include <linux/typecheck.h>
> +#include <linux/stddef.h>
>  
>  /**
>   * for_each_if - helper for handling conditionals in various for_each macros
> -- 
> 2.47.2