linux-kernel - Re: [PATCH] usbip: set the dma mask to 64bit default for vhci-driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <575ce02c-9128-4098-a852-d9e14f14010e@163.com>
Date: Mon, 28 Apr 2025 17:51:08 +0800
From: Zongmin Zhou <min_halo@....com>
To: Greg KH <gregkh@...uxfoundation.org>,
 Shuah Khan <skhan@...uxfoundation.org>
Cc: Christoph Hellwig <hch@...radead.org>, i@...ithal.me,
 linux-kernel@...r.kernel.org, linux-usb@...r.kernel.org, shuah@...nel.org,
 valentina.manea.m@...il.com, Zongmin Zhou <zhouzongmin@...inos.cn>
Subject: Re: [PATCH] usbip: set the dma mask to 64bit default for vhci-driver

Dear Greg and Shuah,

I found out that the vhci-hcd driver added this virtual device
as a platform device from the very beginning since 2014.
I'm just getting in touch with this module and
don't have a deep understanding of it，shuah should be clearer.

I don't know if using the faux bus to replace the platform bus can solve 
the problem
that the error limitation on max_hw_sectors for usbip device since 
commit d74ffae8b8dd applied.
But this change will request user to update kernel version to support 
faux bus.
This will also be an expensive change to fix the problem?

I have been discussing with shuah for a long time.
Is there any simpler way to fix this problem?

On 2025/4/25 16:28, Greg KH wrote:
> On Fri, Apr 25, 2025 at 04:08:47PM +0800, Zongmin Zhou wrote:
>> Dear Greg and Christoph:
>>
>> This patch is the simple solution for the issue described in below link:
>> https://lore.kernel.org/all/20250219092555.112631-1-min_halo@163.com/
>>
>> This issue has been discussed at length with Shuah.
>>
>> As Christoph said,vhci-hcd is a virtual hci,
>> but it serves as a bridge to connect virtual USB devices to the real USB
>> controller.
>> Since the commit d74ffae8b8dd is applied on kernel v5.3,
>> the virtual USB devices's max_sectors size is limited since v5.3.
>>
>> Just because on vhci-hcd, the dma mask setting follows the platform device
>> default setting(32-bit).
> Wait, why is vhci-hcd a platform device at all?  It shouldn't be doing
> that, try removing that to start with, which will remove that "default"
> setting.  I recommend using the faux bus as a potential replacement.
>
> thanks,
>
> greg k-h