linux-kernel - Re: [PATCH] block: rnbd: add .release to rnbd_dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAMGffEnT+C2xSNXuEFzGm9Yh_f=sRVrPsFO=tSasLMWciqKPhw@mail.gmail.com>
Date: Mon, 28 Apr 2025 11:58:55 +0200
From: Jinpu Wang <jinpu.wang@...os.com>
To: Salah Triki <salah.triki@...il.com>
Cc: "Md. Haris Iqbal" <haris.iqbal@...os.com>, Jens Axboe <axboe@...nel.dk>, linux-block@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] block: rnbd: add .release to rnbd_dev_ktype

Hi,

On Sun, Apr 27, 2025 at 5:48 PM Salah Triki <salah.triki@...il.com> wrote:
>
> Every ktype must provides a .release function that will be called after
> the last kobject_put.
>
> Signed-off-by: Salah Triki <salah.triki@...il.com>
This change cause crashing during unmap device.
We already have rnbd_client_release from rnbd_client_ops, so no memleak.

Nacked.

Thx!
> ---
>  drivers/block/rnbd/rnbd-clt-sysfs.c | 8 ++++++++
>  1 file changed, 8 insertions(+)
>
> diff --git a/drivers/block/rnbd/rnbd-clt-sysfs.c b/drivers/block/rnbd/rnbd-clt-sysfs.c
> index 6ea7c12e3a87..144aea1466a4 100644
> --- a/drivers/block/rnbd/rnbd-clt-sysfs.c
> +++ b/drivers/block/rnbd/rnbd-clt-sysfs.c
> @@ -475,9 +475,17 @@ void rnbd_clt_remove_dev_symlink(struct rnbd_clt_dev *dev)
>         }
>  }
>
> +static void rnbd_dev_release(struct kobject *kobj)
> +{
> +       struct rnbd_clt_dev *dev = container_of(kobj, struct rnbd_clt_dev, kobj);
> +
> +       kfree(dev);
> +}
> +
>  static const struct kobj_type rnbd_dev_ktype = {
>         .sysfs_ops      = &kobj_sysfs_ops,
>         .default_groups = rnbd_dev_groups,
> +       .release        = rnbd_dev_release,
>  };
>
>  static int rnbd_clt_add_dev_kobj(struct rnbd_clt_dev *dev)
> --
> 2.43.0
>