linux-kernel - RE: [PATCH] mei: Cast the cb->ext

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CY5PR11MB6366D67DDBB99F7A6824D968ED812@CY5PR11MB6366.namprd11.prod.outlook.com>
Date: Mon, 28 Apr 2025 10:43:29 +0000
From: "Usyskin, Alexander" <alexander.usyskin@...el.com>
To: Kees Cook <kees@...nel.org>
CC: Arnd Bergmann <arnd@...db.de>, Greg Kroah-Hartman
	<gregkh@...uxfoundation.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "linux-hardening@...r.kernel.org"
	<linux-hardening@...r.kernel.org>
Subject: RE: [PATCH] mei: Cast the cb->ext_hdr allocation type

> Subject: [PATCH] mei: Cast the cb->ext_hdr allocation type
> 
> In preparation for making the kmalloc family of allocators type aware,
> we need to make sure that the returned type from the allocation matches
> the type of the variable being assigned. (Before, the allocator would
> always return "void *", which can be implicitly cast to any pointer type.)
> 
> The assigned type is "struct mei_ext_hdr *", but the returned type will
> be "struct mei_ext_hdr_gsc_f2h *", which is a larger allocation size.
> This is by design as struct mei_ext_hdr_gsc_f2h contains struct
> mei_ext_hdr as its first member. Cast the allocation to the match the
> assignment.
> 

Acked-by: Alexander Usyskin <alexander.usyskin@...el.com>

> Signed-off-by: Kees Cook <kees@...nel.org>
> ---
> Cc: Alexander Usyskin <alexander.usyskin@...el.com>
> Cc: Arnd Bergmann <arnd@...db.de>
> Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> ---
>  drivers/misc/mei/interrupt.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/misc/mei/interrupt.c b/drivers/misc/mei/interrupt.c
> index b09b79fedaba..c484f416fae4 100644
> --- a/drivers/misc/mei/interrupt.c
> +++ b/drivers/misc/mei/interrupt.c
> @@ -133,7 +133,7 @@ static int mei_cl_irq_read_msg(struct mei_cl *cl,
>  				break;
>  			case MEI_EXT_HDR_GSC:
>  				gsc_f2h = (struct mei_ext_hdr_gsc_f2h *)ext;
> -				cb->ext_hdr = kzalloc(sizeof(*gsc_f2h),
> GFP_KERNEL);
> +				cb->ext_hdr = (struct mei_ext_hdr
> *)kzalloc(sizeof(*gsc_f2h), GFP_KERNEL);
>  				if (!cb->ext_hdr) {
>  					cb->status = -ENOMEM;
>  					goto discard;
> --
> 2.34.1