linux-kernel - RE: [PATCH net] fec: Workaround for ERR007885 on fec_enet_txq_submit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <PAXPR04MB85101DD9C5F45DC4BFB200A988812@PAXPR04MB8510.eurprd04.prod.outlook.com>
Date: Mon, 28 Apr 2025 11:26:42 +0000
From: Wei Fang <wei.fang@....com>
To: "mattiasbarthel@...il.com" <mattiasbarthel@...il.com>
CC: "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, Mattias
 Barthel <mattias.barthel@...ascopco.com>, "davem@...emloft.net"
	<davem@...emloft.net>, "edumazet@...gle.com" <edumazet@...gle.com>,
	"kuba@...nel.org" <kuba@...nel.org>, "pabeni@...hat.com" <pabeni@...hat.com>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: RE: [PATCH net] fec: Workaround for ERR007885 on
 fec_enet_txq_submit_skb()

> > From: Mattias Barthel <mattias.barthel@...ascopco.com>
> >
> > Activate workaround also in fec_enet_txq_submit_skb() for when TSO is
> > not enbabled.
> 
> Each line of the commit message should not exceed 75 characters
> 
> >
> > Errata: ERR007885
> > Symptoms: NETDEV WATCHDOG: eth0 (fec): transmit queue 0 timed out
> >
> > reference commit 37d6017b84f7 ("net: fec: Workaround for imx6sx enet
> > tx hang when enable three queues"),
> >
> 
> Please add a Fixes tag before Signed-off-by tag, I think the Fixes tag should be:
> 
> Fixes: 53bb20d1faba ("net: fec: add variable reg_desc_active to speed things up ")
                                                                  ^
Sorry, please remove this space when copying this line.

> 
> > Signed-off-by: Mattias Barthel <mattias.barthel@...ascopco.com>
> > ---
> >  drivers/net/ethernet/freescale/fec_main.c | 7 ++++++-
> >  1 file changed, 6 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/net/ethernet/freescale/fec_main.c
> > b/drivers/net/ethernet/freescale/fec_main.c
> > index a86cfebedaa8..17e9bddb9ddd 100644
> > --- a/drivers/net/ethernet/freescale/fec_main.c
> > +++ b/drivers/net/ethernet/freescale/fec_main.c
> > @@ -714,7 +714,12 @@ static int fec_enet_txq_submit_skb(struct
> > fec_enet_priv_tx_q *txq,
> >         txq->bd.cur = bdp;
> >
> >         /* Trigger transmission start */
> > -       writel(0, txq->bd.reg_desc_active);
> > +       if (!(fep->quirks & FEC_QUIRK_ERR007885) ||
> > +           !readl(txq->bd.reg_desc_active) ||
> > +           !readl(txq->bd.reg_desc_active) ||
> > +           !readl(txq->bd.reg_desc_active) ||
> > +           !readl(txq->bd.reg_desc_active))
> > +               writel(0, txq->bd.reg_desc_active);
> >
> >         return 0;
> >  }
> > --
> > 2.43.0