linux-kernel - Re: [PATCH v7 5/6] gpio: max77759: add Maxim MAX77759 gpio driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a365be041bab36fe20e1e5d34b583d3b350a488d.camel@linaro.org>
Date: Mon, 28 Apr 2025 12:54:55 +0100
From: André Draszik <andre.draszik@...aro.org>
To: Bartosz Golaszewski <brgl@...ev.pl>
Cc: Lee Jones <lee@...nel.org>, Rob Herring <robh@...nel.org>, Krzysztof
 Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, Linus
 Walleij	 <linus.walleij@...aro.org>, Kees Cook <kees@...nel.org>, "Gustavo
 A. R. Silva"	 <gustavoars@...nel.org>, Srinivas Kandagatla
 <srini@...nel.org>, Peter Griffin	 <peter.griffin@...aro.org>, Tudor
 Ambarus <tudor.ambarus@...aro.org>, Will McVicker
 <willmcvicker@...gle.com>, kernel-team@...roid.com,
 linux-kernel@...r.kernel.org, 	devicetree@...r.kernel.org,
 linux-gpio@...r.kernel.org, 	linux-hardening@...r.kernel.org, Bartosz
 Golaszewski	 <bartosz.golaszewski@...aro.org>
Subject: Re: [PATCH v7 5/6] gpio: max77759: add Maxim MAX77759 gpio driver

Hi Bartosz,

On Mon, 2025-04-28 at 13:43 +0200, Bartosz Golaszewski wrote:
> On Mon, Apr 28, 2025 at 1:36 PM André Draszik <andre.draszik@...aro.org> wrote:
> > 
> > The Maxim MAX77759 is a companion PMIC for USB Type-C applications and
> > includes Battery Charger, Fuel Gauge, temperature sensors, USB Type-C
> > Port Controller (TCPC), NVMEM, and a GPIO expander.
> > 
> > This driver supports the GPIO functions using the platform device
> > registered by the core MFD driver.
> > 
> > Reviewed-by: Linus Walleij <linus.walleij@...aro.org>
> > Acked-by: Bartosz Golaszewski <bartosz.golaszewski@...aro.org>
> > Signed-off-by: André Draszik <andre.draszik@...aro.org>
> > ---
> 
> [snip]
> 
> > +
> > +       chip->gc.names = max77759_gpio_line_names;
> > +       chip->gc.ngpio = MAX77759_N_GPIOS;
> > +       chip->gc.get_direction = max77759_gpio_get_direction;
> > +       chip->gc.direction_input = max77759_gpio_direction_input;
> > +       chip->gc.direction_output = max77759_gpio_direction_output;
> > +       chip->gc.get = max77759_gpio_get_value;
> > +       chip->gc.set = max77759_gpio_set_value;
> 
> Please use the set_rv variant now, the old set is deprecated. Until
> that's changed, my Ack is revoked.

Thanks Bartosz for pointing this out, will update.

Cheers,
Andre'