| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <b1a48f29-c0ef-2c9b-b8e7-0d3766fd9cc2@quicinc.com>
Date: Mon, 28 Apr 2025 17:41:19 +0530
From: Dikshita Agarwal <quic_dikshita@...cinc.com>
To: Dmitry Baryshkov <dmitry.baryshkov@....qualcomm.com>
CC: Vikash Garodia <quic_vgarodia@...cinc.com>,
Abhinav Kumar
<quic_abhinavk@...cinc.com>,
Mauro Carvalho Chehab <mchehab@...nel.org>,
Stefan Schmidt <stefan.schmidt@...aro.org>,
Hans Verkuil
<hverkuil@...all.nl>,
Bjorn Andersson <andersson@...nel.org>,
Konrad Dybcio
<konradybcio@...nel.org>, Rob Herring <robh@...nel.org>,
Krzysztof Kozlowski
<krzk+dt@...nel.org>,
Conor Dooley <conor+dt@...nel.org>,
Bryan O'Donoghue
<bryan.odonoghue@...aro.org>,
Neil Armstrong <neil.armstrong@...aro.org>,
Nicolas Dufresne <nicolas.dufresne@...labora.com>,
<linux-media@...r.kernel.org>, <linux-arm-msm@...r.kernel.org>,
<linux-kernel@...r.kernel.org>, <devicetree@...r.kernel.org>,
<20250417-topic-sm8x50-iris-v10-v7-0-f020cb1d0e98@...aro.org>,
<20250424-qcs8300_iris-v5-0-f118f505c300@...cinc.com>,
<stable@...r.kernel.org>, Dan Carpenter <dan.carpenter@...aro.org>
Subject: Re: [PATCH v2 00/23] Add support for HEVC and VP9 codecs in decoder
On 4/28/2025 4:37 PM, Dmitry Baryshkov wrote:
> On Mon, Apr 28, 2025 at 02:58:48PM +0530, Dikshita Agarwal wrote:
>> Hi All,
>>
>> This patch series adds initial support for the HEVC(H.265) and VP9
>> codecs in iris decoder. The objective of this work is to extend the
>> decoder's capabilities to handle HEVC and VP9 codec streams,
>> including necessary format handling and buffer management.
>> In addition, the series also includes a set of fixes to address issues
>> identified during testing of these additional codecs.
>>
>> These patches also address the comments and feedback received from the
>> RFC patches previously sent. I have made the necessary improvements
>> based on the community's suggestions.
>>
>> Changes in v2:
>> - Added Changes to make sure all buffers are released in session close
>> (bryna)
>> - Added tracking for flush responses to fix a timing issue.
>> - Added a handling to fix timing issue in reconfig
>> - Splitted patch 06/20 in two patches (Bryan)
>> - Added missing fixes tag (bryan)
>> - Updated fluster report (Nicolas)
>> - Link to v1:
>> https://lore.kernel.org/r/20250408-iris-dec-hevc-vp9-v1-0-acd258778bd6@quicinc.com
>>
>> Changes sinces RFC:
>> - Added additional fixes to address issues identified during further
>> testing.
>> - Moved typo fix to a seperate patch [Neil]
>> - Reordered the patches for better logical flow and clarity [Neil,
>> Dmitry]
>> - Added fixes tag wherever applicable [Neil, Dmitry]
>> - Removed the default case in the switch statement for codecs [Bryan]
>> - Replaced if-else statements with switch-case [Bryan]
>> - Added comments for mbpf [Bryan]
>> - RFC:
>> https://lore.kernel.org/linux-media/20250305104335.3629945-1-quic_dikshita@quicinc.com/
>>
>> This patch series depends on [1] & [2]
>> [1] https://lore.kernel.org/linux-media/20250417-topic-sm8x50-iris-v10-v7-0-f020cb1d0e98@linaro.org/
>> [2] https://lore.kernel.org/linux-media/20250424-qcs8300_iris-v5-0-f118f505c300@quicinc.com/
>>
>
> [...]
>
>>
>> Signed-off-by: Dikshita Agarwal <quic_dikshita@...cinc.com>
>> ---
>> Dikshita Agarwal (23):
>> media: iris: Skip destroying internal buffer if not dequeued
>> media: iris: Update CAPTURE format info based on OUTPUT format
>> media: iris: Add handling for corrupt and drop frames
>> media: iris: Avoid updating frame size to firmware during reconfig
>> media: iris: Send V4L2_BUF_FLAG_ERROR for buffers with 0 filled length
>> media: iris: Drop port check for session property response
>> media: iris: Add handling for no show frames
>> media: iris: Improve last flag handling
>> media: iris: Skip flush on first sequence change
>> media: iris: Prevent HFI queue writes when core is in deinit state
>> media: iris: Remove redundant buffer count check in stream off
>
> Please move all fixes patches to the beginning of the series. This helps
> maintainers to pick them up for the -fixes branches.
>
Ack.
Thanks,
Dikshita
>> media: iris: Remove deprecated property setting to firmware
>> media: iris: Fix missing function pointer initialization
>> media: iris: Fix NULL pointer dereference
>> media: iris: Fix typo in depth variable
>> media: iris: Add a comment to explain usage of MBPS
>> media: iris: Track flush responses to prevent premature completion
>> media: iris: Fix buffer preparation failure during resolution change
>> media: iris: Add HEVC and VP9 formats for decoder
>> media: iris: Add platform capabilities for HEVC and VP9 decoders
>> media: iris: Set mandatory properties for HEVC and VP9 decoders.
>> media: iris: Add internal buffer calculation for HEVC and VP9 decoders
>> media: iris: Add codec specific check for VP9 decoder drain handling
>>
>> drivers/media/platform/qcom/iris/iris_buffer.c | 52 ++-
>> drivers/media/platform/qcom/iris/iris_buffer.h | 3 +-
>> drivers/media/platform/qcom/iris/iris_ctrls.c | 35 +-
>> drivers/media/platform/qcom/iris/iris_hfi_common.h | 1 +
>> .../platform/qcom/iris/iris_hfi_gen1_command.c | 48 ++-
>> .../platform/qcom/iris/iris_hfi_gen1_defines.h | 5 +-
>> .../platform/qcom/iris/iris_hfi_gen1_response.c | 39 +-
>> .../platform/qcom/iris/iris_hfi_gen2_command.c | 143 +++++++-
>> .../platform/qcom/iris/iris_hfi_gen2_defines.h | 5 +
>> .../platform/qcom/iris/iris_hfi_gen2_response.c | 58 ++-
>> drivers/media/platform/qcom/iris/iris_hfi_queue.c | 2 +-
>> drivers/media/platform/qcom/iris/iris_instance.h | 8 +
>> .../platform/qcom/iris/iris_platform_common.h | 28 +-
>> .../media/platform/qcom/iris/iris_platform_gen2.c | 198 ++++++++--
>> .../platform/qcom/iris/iris_platform_qcs8300.h | 126 +++++--
>> .../platform/qcom/iris/iris_platform_sm8250.c | 15 +-
>> drivers/media/platform/qcom/iris/iris_vb2.c | 18 +-
>> drivers/media/platform/qcom/iris/iris_vdec.c | 117 +++---
>> drivers/media/platform/qcom/iris/iris_vdec.h | 11 +
>> drivers/media/platform/qcom/iris/iris_vidc.c | 9 +-
>> drivers/media/platform/qcom/iris/iris_vpu_buffer.c | 397 ++++++++++++++++++++-
>> drivers/media/platform/qcom/iris/iris_vpu_buffer.h | 46 ++-
>> 22 files changed, 1154 insertions(+), 210 deletions(-)
>> ---
>> base-commit: 398a1b33f1479af35ca915c5efc9b00d6204f8fa
>> change-id: 20250428-qcom-iris-hevc-vp9-eb31f30c3390
>> prerequisite-message-id: <20250417-topic-sm8x50-iris-v10-v7-0-f020cb1d0e98@...aro.org>
>> prerequisite-patch-id: 35f8dae1416977e88c2db7c767800c01822e266e
>> prerequisite-patch-id: 2bba98151ca103aa62a513a0fbd0df7ae64d9868
>> prerequisite-patch-id: 0e43a6d758b5fa5ab921c6aa3c19859e312b47d0
>> prerequisite-patch-id: b7b50aa1657be59fd51c3e53d73382a1ee75a08e
>> prerequisite-patch-id: 30960743105a36f20b3ec4a9ff19e7bca04d6add
>> prerequisite-patch-id: b93c37dc7e09d1631b75387dc1ca90e3066dce17
>> prerequisite-patch-id: afffe7096c8e110a8da08c987983bc4441d39578
>> prerequisite-message-id: <20250424-qcs8300_iris-v5-0-f118f505c300@...cinc.com>
>> prerequisite-patch-id: 2e72fe4d11d264db3d42fa450427d30171303c6f
>> prerequisite-patch-id: 3398937a7fabb45934bb98a530eef73252231132
>> prerequisite-patch-id: feda620f147ca14a958c92afdc85a1dc507701ac
>> prerequisite-patch-id: 07ba0745c7d72796567e0a57f5c8e5355a8d2046
>> prerequisite-patch-id: e35b05c527217206ae871aef0d7b0261af0319ea
>>
>> Best regards,
>> --
>> Dikshita Agarwal <quic_dikshita@...cinc.com>
>>
>
Powered by blists - more mailing lists