linux-kernel - Re: [PATCH v2 1/3] PCI: Export pci_msix_prepare

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87ldrkqxum.ffs@tglx>
Date: Mon, 28 Apr 2025 14:22:57 +0200
From: Thomas Gleixner <tglx@...utronix.de>
To: Bjorn Helgaas <helgaas@...nel.org>, Shradha Gupta
 <shradhagupta@...ux.microsoft.com>
Cc: linux-hyperv@...r.kernel.org, linux-pci@...r.kernel.org,
 linux-kernel@...r.kernel.org, Nipun Gupta <nipun.gupta@....com>, Yury
 Norov <yury.norov@...il.com>, Jason Gunthorpe <jgg@...pe.ca>, Jonathan
 Cameron <Jonathan.Cameron@...ei.com>, Anna-Maria Behnsen
 <anna-maria@...utronix.de>, Kevin Tian <kevin.tian@...el.com>, Long Li
 <longli@...rosoft.com>, Bjorn Helgaas <bhelgaas@...gle.com>, Rob Herring
 <robh@...nel.org>, Manivannan Sadhasivam
 <manivannan.sadhasivam@...aro.org>, Krzysztof Wilczyński
 <kw@...ux.com>,
 Lorenzo Pieralisi <lpieralisi@...nel.org>, Dexuan Cui
 <decui@...rosoft.com>, Wei Liu <wei.liu@...nel.org>, Haiyang Zhang
 <haiyangz@...rosoft.com>, "K. Y. Srinivasan" <kys@...rosoft.com>, Andrew
 Lunn <andrew+netdev@...n.ch>, "David S. Miller" <davem@...emloft.net>,
 Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>,
 Paolo Abeni <pabeni@...hat.com>, Konstantin Taranov
 <kotaranov@...rosoft.com>, Simon Horman <horms@...nel.org>, Leon
 Romanovsky <leon@...nel.org>, Maxim Levitsky <mlevitsk@...hat.com>, Erni
 Sri Satya Vennela <ernis@...ux.microsoft.com>, Peter Zijlstra
 <peterz@...radead.org>, netdev@...r.kernel.org,
 linux-rdma@...r.kernel.org, Paul Rosswurm <paulros@...rosoft.com>, Shradha
 Gupta <shradhagupta@...rosoft.com>
Subject: Re: [PATCH v2 1/3] PCI: Export pci_msix_prepare_desc() for dynamic
 MSI-X alloc

On Fri, Apr 25 2025 at 11:37, Bjorn Helgaas wrote:

Subject prefix wants to be PCI/MSI

  git log --format=oneline path/to/file

gives you a pretty decent hint

> On Fri, Apr 25, 2025 at 03:53:57AM -0700, Shradha Gupta wrote:
>> For supporting dynamic MSI-X vector allocation by PCI controllers, enabling
>> the flag MSI_FLAG_PCI_MSIX_ALLOC_DYN is not enough, msix_prepare_msi_desc()
>> to prepare the desc is also needed.

Please write things out: ... to prepare the MSI descriptor ....

This is not twitter.

>> Export pci_msix_prepare_desc() to allow PCI controllers to support dynamic
>> MSI-X vector allocation.
>> 
>> Signed-off-by: Shradha Gupta <shradhagupta@...ux.microsoft.com>
>> Reviewed-by: Haiyang Zhang <haiyangz@...rosoft.com>

> Thanks for the update and for splitting this from the hv driver
> update.  Will watch for Thomas's ack here.

Other than that:

Reviewed-by: Thomas Gleixner <tglx@...utronix.de>